Skip to content

Swap markdown package from erusev to league #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2021
Merged

Swap markdown package from erusev to league #1294

merged 1 commit into from
Dec 20, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Dec 17, 2021

@javiereguiluz
Copy link
Member

I like this change. erusev parser is faster, but commonmark is the reference implementation, so let's use it.

Note that no code changes are necessary because Twig extension automatically detects several Markdown libraries and picks one of them.

@javiereguiluz javiereguiluz merged commit 5467857 into symfony:main Dec 20, 2021
@94noni 94noni deleted the ft-package-markdown branch December 20, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@94noni @javiereguiluz