-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Rebase and flatpickr #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase and flatpickr #1412
Conversation
Thanks for this contribution. Let's see if this time we can finish and merge this 🙏 I tested it locally and found some issues. (1) The datepicker doesn't work for me: And the error details: (2) Some spacing and font sizes look too different. The new design doesn't have to be identical to before, but it should be closer. See before/after comparisons: In the above screenshot, let's tweak the top bar and the form fields to look like before, but let's keep the new bi buttons because they look better than before. |
The language spotter in flatpicker.js is now fixed, just an oversight. At first I added the language as a data-attribute of the body, but I finally said to myself that it was already present in the html tag, so I had corrected too quickly... You can now test the feature, I'll have a look for design adaptations. |
These differences come from the change to Bootstrap 4 and conforms to the standard Bootstrap 4 interface standards. Units are basically changed to rem rather than pixels. I'm not sure I've mastered these concepts enough to act properly on the interface, but if someone reading this in the assembly is an UX/UI master, show up with pleasure! |
… 3 one (atierant)
@javiereguiluz Fixed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and everything worked as expected.
Thanks @atierant for this brilliant contribution!
Good job @atierant |
This is now merged! Thanks Arnaud. |
Rebase @bechir work to comply with 6.2 branch
Resolve #1183
Fix flatpickr as mandated by @bechir in #1183 (comment)