disable the deprecated sensio_framework_extra.router.annotations

[christickner]

fixes #786

famework.annotations still needs to be true due to the validation: { enable_annotations: true } in framework.yaml.

Should I move the framework.annotations: true to the framework.yaml file instead? It seems more appropriate.

[javiereguiluz]

Not sure what's the best choice. Let's ask for help to some expert developers who are active in this repo: @voronkovich @bocharsky-bw @yceruto. Thanks!

[stof]

Why do we have framework_extra.yml configuring framework ? this looks weird (and useless, as FrameworkBundle already enables the annotation layer properly based on the fact that doctrine/annotations is installed)

[voronkovich]

I agree with @stof. I think we should just delete the framework_extra.yml file.

[christickner]

agreed. removed the "framework" config from the file here: a063862

@voronkovich note that we can't delete the file entirely, as we have to explicitly disable sensio_framework_extra.router.annotations for this issue to be solved.

All: should I squash, rebase on master, and force-push, or are we okay as is?

[javiereguiluz]

@christickner thanks for your work on this! There's no need to squash or rebase because the tool we use to merge things do that automatically. Cheers!

[javiereguiluz]

...and it's merged! Thank you!