Enabled the no_superfluous_phpdoc_tags fixer rule #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jul 20, 2018
…guiluz) This PR was merged into the master branch. Discussion ---------- Enabled the no_superfluous_phpdoc_tags fixer rule Our code was already good 😎 ... but this rule removed some unneeded PHPdoc. Commits ------- f8483c2 Enabled the no_superfluous_phpdoc_tags fixer rule
stof
reviewed
Jul 20, 2018
| @@ -121,8 +119,6 @@ private function getMockedTransformer(array $findByReturnValues = []): TagArrayT | |||
| * This helper method creates a Tag instance for the given tag name. | |||
| * | |||
| * @param string $name | |||
There was a problem hiding this comment.
should this be moved to a typehint too ?
javiereguiluz
added a commit
that referenced
this pull request
Jul 26, 2018
This PR was merged into the master branch. Discussion ---------- Added more type hints and removed PHPdoc A follow-up of #837 after this comment from @stof: https://github.com/symfony/demo/pull/837/files/f8483c27636eafa5a56302ba6daac04dcd36e8fa#r204007113 Commits ------- 4f177c3 Added more type hints and removed PHPdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code was already good 😎 ... but this rule removed some unneeded PHPdoc.