Fixed the has_role() deprecation #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Oct 5, 2018
This PR was merged into the master branch. Discussion ---------- Fixed the has_role() deprecation This is a deprecation introduced by the upgrade to Symfony 4.2 in #865. ``` 14x: Using the "has_role()" function in security expressions is deprecated since Symfony 4.2, use "is_granted()" instead. 2x in BlogControllerTest::testAdminNewPost from App\Tests\Controller\Admin 2x in BlogControllerTest::testAdminEditPost from App\Tests\Controller\Admin 2x in BlogControllerTest::testAdminDeletePost from App\Tests\Controller\Admin 2x in UserControllerTest::testAccessDeniedForAnonymousUsers from App\Tests\Controller 2x in UserControllerTest::testEditUser from App\Tests\Controller 2x in UserControllerTest::testChangePassword from App\Tests\Controller 1x in BlogControllerTest::testAdminBackendHomePage from App\Tests\Controller\Admin 1x in BlogControllerTest::testAdminShowPost from App\Tests\Controller\Admin ``` Commits ------- 51b5135 Fixed the has_role() deprecation
stof
reviewed
Oct 5, 2018
| @@ -33,7 +33,7 @@ | |||
| * See http://knpbundles.com/keyword/admin | |||
| * | |||
| * @Route("/admin/post") | |||
| * @Security("has_role('ROLE_ADMIN')") | |||
| * @Security("is_granted('ROLE_ADMIN')") | |||
There was a problem hiding this comment.
even better would be to migrate to the @IsGranted annotation of FrameworkExtraBundle rather than @Security for all these @Security("is_granted(...)") cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a deprecation introduced by the upgrade to Symfony 4.2 in #865.