Update README.rst #447
Merged
Update README.rst #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix a typo according to https://github.com/symfony/flex/blob/fabf04baa532b8068558d1e54a9358ef26814449/src/Flex.php#L404, though it doesn't work currently, see symfony/demo#842
ghost
deployed
to
maxhelias
approved these changes
Aug 9, 2018
fabpot
reviewed
Aug 10, 2018
README.rst
Outdated
| @@ -222,7 +222,7 @@ script (``php-script`` for PHP scripts, ``script`` for any shell script and | |||
| .. code-block:: json | |||
|
|
|||
| { | |||
| "composer-scripts": { | |||
| "auto-scripts": { | |||
There was a problem hiding this comment.
We should probably add the wrapping scripts entry to make it very clear. WDTY?
There was a problem hiding this comment.
Sorry for the delay, done.
fabpot
approved these changes
Sep 4, 2018
|
Wasn't this section meant to describe the format of the configurator in the |
|
fore example, see recipes/symfony/framework-bundle/3.3/manifest.json Lines 10 to 13 in 9f97317 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix a typo according to https://github.com/symfony/flex/blob/fabf04baa532b8068558d1e54a9358ef26814449/src/Flex.php#L404, though it doesn't work currently, see symfony/demo#842