ensure $_ENV is contains real env vars from $_SERVER , or defaults from .env.local.php #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
deployed
to
bendavies
force-pushed
the
symfony-bootstrap-overwrite-dumped-env
branch
from
53e308f to
d89bd96
Compare
bendavies
force-pushed
the
symfony-bootstrap-overwrite-dumped-env
branch
from
d89bd96 to
65dc172
Compare
nicolas-grekas
approved these changes
Jun 14, 2019
dunglas
approved these changes
Jun 14, 2019
bocharsky-bw
added a commit
to bocharsky-bw/demo
that referenced
this pull request
Jun 14, 2019
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Jun 14, 2019
This PR was merged into the master branch. Discussion ---------- Apply latest changes in FWBundle recipe See symfony/recipes#611 Commits ------- 11def45 Apply latest changes in FWBundle recipe
|
@nicolas-grekas // @javiereguiluz It took down our production and was hard to debug since in the documentation it's clearly saying that real env var takes over the var contained on those files. |
|
The same thing happened to us @tristanbes and I totally agree this needs to get more attention — possibly a blog post? |
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Apply latest changes in FWBundle recipe See symfony/recipes#611 Commits ------- 11def45 Apply latest changes in FWBundle recipe
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Apply latest changes in FWBundle recipe See symfony/recipes#611 Commits ------- 11def45 Apply latest changes in FWBundle recipe
muqeetsyed
pushed a commit
to muqeetsyed/docker-symfony
that referenced
this pull request
Dec 26, 2024
frederickboyd
added a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
frederickboyd
added a commit
to frederickboyd/frederickboyd
that referenced
this pull request
May 25, 2025
This PR was merged into the master branch. Discussion ---------- Apply latest changes in FWBundle recipe See symfony/recipes#611 Commits ------- 11def45 Apply latest changes in FWBundle recipe
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where by
.env.local.phpwas not overridable by real env vars.