Skip to content

Adding CHANGELOG #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Adding CHANGELOG #17

merged 1 commit into from
Jan 24, 2021

Conversation

weaverryan
Copy link
Member

Hi!

I'd personally like a CHANGELOG - I rely on them a lot in the JS world, as things change a lot. And also, with the breaking change in 1.2.0, I think it would help.

Cheers!

@tgalopin
Copy link
Contributor

Thanks Ryan.

@tgalopin tgalopin merged commit 6696ed4 into symfony:main Jan 24, 2021
tgalopin added a commit that referenced this pull request Jan 24, 2021
This PR was merged into the main branch.

Discussion
----------

removing old files for the plugin

These are extra files I missed in #14

After these are deleted, the error in I added to the readme in #17 will occur if you use the updated version of this lib with an outdated Encore version.

Thanks!

Commits
-------

017ff71 removing old files for the plugin
@stof
Copy link
Member

stof commented Jan 25, 2021

And also, with the breaking change in 1.2.0, I think it would help.

this should be a 2.0, not a 1.2.0 if it has breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants