Skip to content

Document the removal of getArguments() from ControllerResolverInterface #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 12, 2017 · 0 comments
Closed

Document the removal of getArguments() from ControllerResolverInterface #8626

javiereguiluz opened this issue Nov 12, 2017 · 0 comments
Labels
bug hasPR A Pull Request has already been submitted for this issue. HttpKernel Status: Needs Review
Milestone
4.0

Comments

@javiereguiluz
Copy link
Member

In #8622 we removed deprecated things from docs, but I couldn't remove the deprecated mentions to ControllerResolverInterface::getArguments() because I don't fully understand them.

The mentions are in:

  • components/http_kernel.rst
  • create_framework/http_kernel_controller_resolver.rst

@iltar knows this feature inside out, so he may try to make this change. Thanks!
@javiereguiluz javiereguiluz added this to the 4.0 milestone Nov 12, 2017
@linaori linaori mentioned this issue Nov 13, 2017
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Nov 13, 2017
wouterj added a commit that referenced this issue Nov 13, 2017
@wouterj
feature #8636 Removed deprecations for argument/controller resolvers …
f95209f 
…(iltar)

This PR was merged into the master branch.

Discussion
----------

Removed deprecations for argument/controller resolvers

I've removed the deprecation mentions and updated some text/examples to be correct for 4.0.

Closes #8626.

Commits
-------

3b27a3d Removed deprecations for argument/controller resolvers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hasPR A Pull Request has already been submitted for this issue. HttpKernel Status: Needs Review
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @carsonbot