Skip to content

extra.symfony-public-dir is gone, right? #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dzuelke opened this issue Nov 28, 2017 · 8 comments
Closed

extra.symfony-public-dir is gone, right? #8766

dzuelke opened this issue Nov 28, 2017 · 8 comments
Labels
hasPR A Pull Request has already been submitted for this issue.
Milestone

Comments

@dzuelke
Copy link
Contributor

dzuelke commented Nov 28, 2017

In 4.0+, it's config.public-dir, is it not?

https://symfony.com/doc/4.0/configuration/override_dir_structure.html#override-web-dir

And how does this work with 3.4+Flex?

@xabbuh xabbuh added this to the 4.0 milestone Nov 29, 2017
@ghost
Copy link

ghost commented Dec 5, 2017

That is correct:

{
    "extra": {
        "symfony-public-dir": "my_awesome_new_public_dir"
    }
}

For Flex I am unsure if that is changeable: symfony/flex@6bbb7e5/src/Flex.php#diff-46b78198ae7ea525f04268205dd782c3R262

Maybe @fabpot or @javiereguiluz might give a better answer to this. If Flex's public directory is customisable, we will of course create documentation for this.

@dzuelke
Copy link
Contributor Author

dzuelke commented Dec 5, 2017

Where is the code that reads that value, @ricknox, do you know? I didn't find it anywhere. Just the new Flex thing, which appears to be overridable via config in composer.json.

@nicolas-grekas can you shed any light on this?

@ghost
Copy link

ghost commented Dec 18, 2017

@dzuelke This issue has been given some love in #8732 which is part of #8754. It has been changed from symfony-web-dir to symfony-public-dir. But that applies for the 4.0 version, which indeed includes Flex.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 18, 2017
@dzuelke
Copy link
Contributor Author

dzuelke commented Dec 24, 2017

But is it really extra.symfony-public-dir, @ricknox? I can't find any reference to it anywhere in the sources. It looks like it's just extra.public-dir now in Flex!? /cc @nicolas-grekas

@kriskoch
Copy link

kriskoch commented Jan 4, 2018

I added "public-dir": "web" to the "extra" config in composer.json and it works with symfony4+flex.

@xabbuh
Copy link
Member

xabbuh commented Jan 8, 2018

see also symfony/symfony#25677

@dzuelke
Copy link
Contributor Author

dzuelke commented Jan 8, 2018

Looks like it's extra.public-dir indeed: https://github.com/symfony/flex/blob/5e610d4b66a1f17736f6025fc81fd794d8ac69d6/src/Flex.php#L353

Idziak added a commit to Idziak/symfony-docs that referenced this issue Jan 19, 2018
javiereguiluz added a commit that referenced this issue Jan 20, 2018
This PR was merged into the 4.0 branch.

Discussion
----------

Change symfony-public-dir to public-dir

As explained in #8766

Commits
-------

5f34f05 Change symfony-public-dir to public-dir
@javiereguiluz
Copy link
Member

Fixed by #9085.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

4 participants