[Deployment] Updated building assets in favor of Encore over Assetic #10238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor reorganization
|
@royklutman thanks for removing the obsolete Assetic stuff. I agree adding a link to building assets with Webpack Encore ... but I prefer to not create a new section called "Things to do before deploying". The reason is that there are multiple things that you can do before the actual deployment ... or after deploying but before publishing the app ... it all depends on your setup and deployment strategy. So, let's keep a single general list of things to do and people should figure out the details. Thanks! |
javiereguiluz
added a commit
that referenced
this pull request
Sep 4, 2018
…over Assetic (royklutman, javiereguiluz) This PR was merged into the 3.4 branch. Discussion ---------- [Deployment] Updated building assets in favor of Encore over Assetic The deployment page isn't up-to-date since we're using Encore instead of Assetic. So in this PR I added a pre-deployment task referring to the explanation of deploying assets using Encore. I also removed the part about dumping the assets using Assetic. If someone could however take a look if I did the reference thing correct, that would be a great help. This PR would close #9887 and close #8094. Commits ------- 53602e6 Update deployment.rst 42498e6 Fixed underline 5375fd6 Added pre-deployment tasks and removed Assetic deployment 430acc6 Added reference to deploying assets
|
@javiereguiluz Yes that makes way more sense indeed, thanks for editing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deployment page isn't up-to-date since we're using Encore instead of Assetic. So in this PR I added a pre-deployment task referring to the explanation of deploying assets using Encore. I also removed the part about dumping the assets using Assetic. If someone could however take a look if I did the reference thing correct, that would be a great help. This PR would close #9887 and close #8094.