-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added deployment Steps on Cloudways #7433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
deployment/cloudways.rst
Outdated
step article describes how to install Symfony on Cloudways servers and how to | ||
deploy Symfony applications using Git and SSH. | ||
|
||
Step 1: Prepare your server and application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prepare Your Server and Application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really add the step numbers in the headlines? This will require a lot of work when steps are not necessary any more in the future or new steps are to be added.
deployment/cloudways.rst
Outdated
.. image:: /_images/deployment/cloudways/select-application.png | ||
:alt: Select PHP Stack in Drop down | ||
|
||
Step 2: Select Cloud Provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select a Cloud Provider
deployment/cloudways.rst
Outdated
Step 2: Select Cloud Provider | ||
----------------------------- | ||
|
||
Now select your favorite cloud provider. You can select any one from the five |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we just write "Select your favorite cloud provider from the list of available providers."? This way we won't have to update the article every time a new provider gets added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xabbuh there is no plan to add more providers yet. so I am changing the line as you say.
deployment/cloudways.rst
Outdated
.. image:: /_images/deployment/cloudways/server-management.png | ||
:alt: server management tab | ||
|
||
In **Basic** tab you can see **PHP Timezone.** Change the server timezone to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the [...]
deployment/cloudways.rst
Outdated
Step 5: SSH Terminal | ||
-------------------- | ||
|
||
After changing server timezone, in **Server Management** click on **Launch SSH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] changing the server [...]
deployment/cloudways.rst
Outdated
.. image:: /_images/deployment/cloudways/symfony-7.png | ||
:alt: login to SSH | ||
|
||
Since the application folder contains a ``index.php`` fie by default, remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[...] an index.php
file [...]
deployment/cloudways.rst
Outdated
:alt: database information | ||
|
||
Open your favorite web browser and access to the "Symfony Welcome page" using | ||
the following URL: http://your_application_url/your_project_directory/web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks wrong to me that you store your entire project in the publicly accessible document root. Is this really the way to go with Cloudways?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should be http://your_staging_url/web
. i am updating it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that would still mean that all your project files will be publicly available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xabbuh No only Web directory is Publicly accessible. Rest are Private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I don't understand why I should append the /web
path.
deployment/cloudways.rst
Outdated
Deploying From Github | ||
====================== | ||
|
||
You can also deploy Symfony application from github. copy the HTTP URL of the repository, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy
deployment/cloudways.rst
Outdated
.. image:: /_images/deployment/cloudways/http_url.png | ||
:alt: symfony homepage | ||
|
||
Open SSH terminal on cloudways Using Master Credentials as shown in Step 5. Move to your project folder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloudways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open an SSH terminal [...]
deployment/cloudways.rst
Outdated
:alt: symfony homepage | ||
|
||
Open SSH terminal on cloudways Using Master Credentials as shown in Step 5. Move to your project folder, | ||
`cd application/{your app folder}/public_html` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reword the sentence to "[...] Move to your project folder and run the clone command there:" and then show both commands in a terminal
code block:
[...] Move to your project folder and run the clone command there:
.. code-block:: terminal
cd application/{your app folder}/public_html
git clone https://github.com/username/your-repository.git
deployment/cloudways.rst
Outdated
|
||
`git clone https://github.com/username/your-repository.git` | ||
|
||
After successfull deployment change your database credentials in **parameters.yml**. you can find your db credentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a successful deployment [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You
deployment/cloudways.rst
Outdated
After successfull deployment change your database credentials in **parameters.yml**. you can find your db credentials | ||
in **Access details** as stated in step 7. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one blank line should be removed
deployment/cloudways.rst
Outdated
|
||
|
||
.. _`Sign up`: https://platform.cloudways.com/signup | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this blank line should be removed (a trailing newline is enough)
@xabbuh I have updated the steps please review it. |
@javiereguiluz @xabbuh What's the status of this pull request? |
@shahroznawaz I'm really sorry but we must close this pull request without merging it. Why? Because as part of the review of Symfony Docs for the upcoming Symfony 4 version, we've decided in #8721 to remove all third-party deployment articles. We've removed Heroku, Platform.sh, etc. So we cannot add new articles about this. Instead of this, we now link to the articles about deploying Symfony apps published by third-party services. Thanks for understanding it. |
Added the steps of launching Symfony applications on Cloudways Cloud Servers.