Updates to Platform.sh deploy instructions #8397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update example PHP version from 5.6 to 7.1 * Files in `.platform` are now required * Endpoint name `php` is better written as `http` * Build flavor `symfony` is better written as `composer` * Rename database from `mysql` to `mydatabase` to separate it clearly from the service type * The `web` section should now use `locations`
OskarStark
requested changes
Oct 6, 2017
| build: | ||
| flavor: symfony | ||
| flavor: composer |
There was a problem hiding this comment.
why do you change this? symfony is correct
There was a problem hiding this comment.
I read somewhere that composer is the new and recommended type for all PHP. Their Symfony template doc use that too: https://docs.platform.sh/frameworks/symfony.html
There was a problem hiding this comment.
good to know, thank you @javiereguiluz 👍
| type: upstream | ||
| # the first part should be your project name | ||
| upstream: 'myphpproject:php' | ||
| upstream: 'myphpproject:http' |
There was a problem hiding this comment.
should be:
'https://{default}/':
type: upstream
upstream: "myphpproject:http"
'https://www.{default}/':
type: redirect
to: "https://{default}/"
|
Refs #8483 |
HeahDude
approved these changes
Oct 10, 2017
| @@ -73,21 +75,21 @@ Platform.sh how to deploy your application (read more about | |||
| deploy: | | |||
| bin/console --env=prod cache:clear | |||
|
|
|||
| For best practices, you should also add a ``.platform`` folder at the root of | |||
| You also need add a ``.platform`` folder at the root of | |||
|
@pjcdawkins thanks for this contribution, but sadly we must close this pull request without merging it. Why? Because in #8721 we decided to remove all these articles explaining how to deploy to third-party services. We now simply link to the articles published by those services. Thanks for understanding it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.platformare now requiredphpis better written ashttpsymfonyis better written ascomposermysqltomydatabaseto separate it clearly from the service typewebsection should now uselocationsThere are probably additional improvements that can be made, referring to the Platform.sh documentation and to the work that has been done in https://github.com/platformsh/platformsh-example-symfony/