Skip to content

Place annotation before the number method #8658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Place annotation before the number method #8658

merged 1 commit into from
Nov 15, 2017

Conversation

relte
Copy link

@relte relte commented Nov 14, 2017

A routing annotation should correspond to a method, not a controller class

An annotation should correspond to a method, not a controller class
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks.

@xabbuh
Copy link
Member

xabbuh commented Nov 15, 2017

Good catch, thanks @Tykzz.

@xabbuh xabbuh merged commit 1c398aa into symfony:master Nov 15, 2017
xabbuh added a commit that referenced this pull request Nov 15, 2017
This PR was merged into the master branch.

Discussion
----------

Place annotation before the number method

A routing annotation should correspond to a method, not a controller class

Commits
-------

1c398aa Place annotation before the number method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants