Updated logging/* articles to Symfony 4 #8683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
requested changes
Nov 17, 2017
| @@ -16,7 +16,7 @@ configuration: | |||
|
|
|||
| .. code-block:: yaml | |||
|
|
|||
| # app/config/config.yml | |||
| # config/packages/monolog.yaml | |||
There was a problem hiding this comment.
I think config/packages/prod/monolog.yaml is more proper - that's really where the user should modify things.
That might affect other logs docs too. In other words, I think we had it wrong before.
|
Status: Needs work |
wouterj
reviewed
Nov 26, 2017
| use Symfony\Component\Console\Input\InputInterface; | ||
| use Symfony\Component\Console\Output\OutputInterface; | ||
|
|
||
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| private $logger; |
There was a problem hiding this comment.
This is becoming quite unreadable. Can we please at the class definition (class .... { }) lines?
weaverryan
added a commit
that referenced
this pull request
Nov 27, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 27, 2017
weaverryan
added a commit
that referenced
this pull request
Nov 27, 2017
* 4.0: (36 commits) Update event_listeners_subscribers.rst Update event_listeners_subscribers.rst [#8683] Tweaks based on feedback [#8643] Removing default values [#8734][#8736] Adding missing installation details fixes thanks to the team! add missing link target for Ansistrano Restored the Assetic tags because they are removed in another PR Corrected a spelling error. Updated Doctrine config reference about bundles Fixed PHP form theme resources Remove App\Bridge\Doctrine\ namespace Fixed the last references to security.yml Updated the main security article Updated security/* articles to Symfony 4 (WIP) Updated security/* articles to Symfony 4 Fixing build problems tweaks thanks to @yceruto updating the rest of the Doctrine docs Update Custom UsernamePasswordToken Authenticator ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.