Skip to content

Updated the translation/* articles to Symfony 4 #8733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2017

Conversation

javiereguiluz
Copy link
Member

No description provided.

@javiereguiluz javiereguiluz changed the base branch from master to 4.0 November 22, 2017 15:17
@yceruto
Copy link
Member

yceruto commented Nov 23, 2017

Could you to update the framework reference to add the default path option? https://github.com/symfony/symfony-docs/pull/8634/files#diff-c0c158a40398b72fa4f0c9d0accbc169

@javiereguiluz
Copy link
Member Author

@yceruto sorry but I can't. I don't see the default_path in my branch or in 4.0. Is this only on master?

@yceruto
Copy link
Member

yceruto commented Nov 23, 2017

@javiereguiluz
Copy link
Member Author

yes, I was referring to the docs ... but I'm probably wrong.

@weaverryan
Copy link
Member

@javiereguiluz He already did the work for you :). @yceruto just wants you to import his work from another PR: https://github.com/symfony/symfony-docs/pull/8634/files#diff-c0c158a40398b72fa4f0c9d0accbc169

Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, then 👍 from me

translation.rst Outdated
------------

In applications using :doc:`Symfony Flex </setup/flex>`, run this command to
install the translator before using it:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not mentioning this in 4.0: I'm assuming they have Flex installed and have that dir structure. If we don't assume this, then the docs become a mess.

translation.rst Outdated
Translations are handled by a ``translator`` service that uses the user's
locale to lookup and return translated messages. Before using it, enable the
``translator`` in your configuration:
The previous creates an initial config file where you can define the default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous command...

translation.rst Outdated
locale to lookup and return translated messages. Before using it, enable the
``translator`` in your configuration:
The previous creates an initial config file where you can define the default
locale of the app and the :ref:`fallback locales <translation-fallback>` used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... fallback locales that will be used if Symfony...

@weaverryan
Copy link
Member

Status: Needs work

@weaverryan weaverryan merged commit eb93259 into symfony:4.0 Nov 27, 2017
weaverryan added a commit that referenced this pull request Nov 27, 2017
…uiluz)

This PR was squashed before being merged into the 4.0 branch (closes #8733).

Discussion
----------

Updated the translation/* articles to Symfony 4

Commits
-------

eb93259 Fixes after Ryan's remarks
aec8b0e Tweaks
8fe3cf0 Updated the translation/* articles to Symfony 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants