Skip to content

! prefix referencing templates #8760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

! prefix referencing templates #8760

wants to merge 3 commits into from

Conversation

silverbackdan
Copy link
Contributor

@yceruto
Copy link
Member

yceruto commented Nov 28, 2017

@silverbackdan thanks for worrying about this! :)

@silverbackdan
Copy link
Contributor Author

No probs, just stumbled across the merged PR and then the docs PR when looking for the answer. If I do this in future, is 1 PR sufficient until approved in master and then PR for the other versions? Didn't really think about it before submitting them all.

@@ -19,6 +19,11 @@ from the bundle to ``app/Resources/AcmeBlogBundle/views/Blog/index.html.twig``
(the ``app/Resources/AcmeBlogBundle`` directory won't exist, so you'll need
to create it). You're now free to customize the template.

If you don't want to override the entire template but instead just want to
override a block, as of Symfony 3.4 you can now do with by extending the original
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the "as of Symfony x.x, you can" are added via the versionadded blocks. Those blocks are removed with the next major I believe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iltar

@nicolas-grekas
Copy link
Member

should we take over this PR? or are you ok to finish it @silverbackdan ?

@silverbackdan
Copy link
Contributor Author

@nicolas-grekas I'm sorry for leaving this - I've made the update to use the versionadd block now. I updated the wording on that file too.

@xabbuh xabbuh added this to the 3.4 milestone Aug 4, 2018
javiereguiluz added a commit that referenced this pull request Sep 6, 2018
This PR was squashed before being merged into the 3.4 branch (closes #8760).

Discussion
----------

! prefix referencing templates

#8440

Commits
-------

a0aec31 ! prefix referencing templates
@javiereguiluz
Copy link
Member

Thanks for this contribution! Sorry we forgot about this and we didn't merge it earlier. @silverbackdan congrats on your first Symfony Docs contribution too!

@David-Crty
Copy link
Contributor

Sorry but it doesn't look to be merged can't find it the in the doc :/
https://symfony.com/doc/current/bundles/override.html

@silverbackdan
Copy link
Contributor Author

I think this has been improved since this was merged. It shows from version 4.1 and above but I think it was implemented in 3.4

@xabbuh
Copy link
Member

xabbuh commented Oct 15, 2018

for 3.4, this part is located in https://symfony.com/doc/3.4/templating/overriding.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants