-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
! prefix referencing templates #8760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@silverbackdan thanks for worrying about this! :) |
No probs, just stumbled across the merged PR and then the docs PR when looking for the answer. If I do this in future, is 1 PR sufficient until approved in master and then PR for the other versions? Didn't really think about it before submitting them all. |
templating/overriding.rst
Outdated
@@ -19,6 +19,11 @@ from the bundle to ``app/Resources/AcmeBlogBundle/views/Blog/index.html.twig`` | |||
(the ``app/Resources/AcmeBlogBundle`` directory won't exist, so you'll need | |||
to create it). You're now free to customize the template. | |||
|
|||
If you don't want to override the entire template but instead just want to | |||
override a block, as of Symfony 3.4 you can now do with by extending the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the "as of Symfony x.x, you can" are added via the versionadded blocks. Those blocks are removed with the next major I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iltar
should we take over this PR? or are you ok to finish it @silverbackdan ? |
@nicolas-grekas I'm sorry for leaving this - I've made the update to use the versionadd block now. I updated the wording on that file too. |
Thanks for this contribution! Sorry we forgot about this and we didn't merge it earlier. @silverbackdan congrats on your first Symfony Docs contribution too! |
Sorry but it doesn't look to be merged can't find it the in the doc :/ |
I think this has been improved since this was merged. It shows from version 4.1 and above but I think it was implemented in 3.4 |
for 3.4, this part is located in https://symfony.com/doc/3.4/templating/overriding.html |
#8440