Skip to content

Updating 2 more articles for 4.0 #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Updating 2 more articles for 4.0 #8798

wants to merge 2 commits into from

Conversation

weaverryan
Copy link
Member

Handles 2 more articles in #8754

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes ... and we still maintain the add-1-remove-2-lines rule 😄 Thanks

</body>
</html>

.. note::

The show ``show.php`` template is left as an exercise: updating it should be
really similar to updating the ``list.php`` template.
The show ``show.html.twig`` template is left as an exercise: updating it should be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The show show.html.twig template... -> The show.html.twig template... ?

weaverryan added a commit that referenced this pull request Dec 1, 2017
This PR was squashed before being merged into the 4.0 branch (closes #8798).

Discussion
----------

Updating 2 more articles for 4.0

Handles 2 more articles in #8754

Commits
-------

22c3614 Updating 2 more articles for 4.0
@weaverryan weaverryan closed this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants