[ProxyManagerBridge] Remove the unused dependency on composer/package-versions-deprecated #44765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ProxyManagerBridge depends on friendsofphp/proxy-manager-lts which has an optional dependency on the PackageVersions class to implement the `ProxyManager\Version::getVersion` method on composer 1 (with a fallback to a less precise version number). However, the bridge has stopped using that API in favor of feature detection, so the dependency is unused.
derrabus
approved these changes
Dec 22, 2021
|
Same in the root package isn't it? |
|
No. the root package only has it as a require-dev, and this should be removed only after removing the dev requirement in doctrine-bridge (which won't be done in 4.4). |
|
Can't we remove the package from require-dev also? Maybe by bumping the min version of some deps, if they remain compatible with PHP 7.1? |
|
Maybe not on 4.4, but 5.3+? 6.0+? |
|
@nicolas-grekas doing that in 5.x (either 5.3 or 5.4) is indeed the plan (see my comment on the RFC issue) |
|
Thank you @stof. |
|
Can you please send a PR on 5.3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProxyManagerBridge depends on friendsofphp/proxy-manager-lts which has an optional dependency on the PackageVersions class to implement the
ProxyManager\Version::getVersionmethod on composer 1 (with a fallback to a less precise version number).However, the bridge has stopped using that API in favor of feature detection (in #39017), so the dependency is unused.
This contributes to #44726