Skip to content

[TwigComponent] Remove obsolete TemplateNameParser #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

sneakyvv
Copy link
Contributor

@sneakyvv sneakyvv commented Jan 16, 2025

It no longer parses (and should not have been stripping namespaces as it did before)

Q A
Bug fix? no
New feature? no
Issues
License MIT

As discussed in #1772 (comment), the code added in #1070 (& expanded in #1082) was not needed (even incorrect, based upon a decorator TemplateIterator of Shopware).

It no longer parses (and should not have been stripping namespaces as it did before)
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jan 16, 2025
@Kocal Kocal changed the title Remove obsolete TemplateNameParser [TwigComponent] Remove obsolete TemplateNameParser Jan 17, 2025
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, i'm very happy to not have to digg again in here :)

And i'm glad we did not do something that created BC.

So everything perfect :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jan 18, 2025
@smnandre
Copy link
Member

Thank you @sneakyvv.

@smnandre smnandre merged commit ec09cdf into symfony:2.x Jan 25, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants