[TwigComponent][Docs] add explicit string cast on string assertions #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
docs
Kocal
approved these changes
Jan 17, 2025
carsonbot
added
Status: Reviewed
|
Indeed, it's a good documentation improvement that will help with silly mistakes. Thanks @Valmonzo |
Valmonzo
deleted the
twigcomponent/add-string-cast-on-rendredcomponent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the examples from the documentation, I realized that if we use the
TestLiveComponent::rendermethod inassertStringContainsStringand if we use strict types, then it throw an error because we try to assert aRenderedComponentobject instead of a string.I think that explicitly adding the cast can help.