Changing webpackMode to fetch - see symfony/stimulus-bridge#15 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2021
Keeping webpackMode for support of people using an old Flex version
weaverryan
force-pushed
the
using-fetch-option
branch
from
65d2ecd to
27f7115
Compare
tgalopin
added a commit
to symfony/stimulus-bridge
that referenced
this pull request
Feb 1, 2021
…sent (weaverryan) This PR was squashed before being merged into the main branch. Discussion ---------- "fetch: lazy": don't download until the controller is present Hi! This deprecates the `webpackMode` option in `controllers.json` and replaces it with a new `lazy` option that can be set to `eager` or `lazy`. The `lazy` mode is quite a bit smarter than the old `webpackMode: 'lazy'`. When you use this, the controller (and its dependencies) isn't downloaded until the corresponding `data-controller` appears on the page. This is great for things like chartjs, which is quite huge, but probably you don't have it on every page and a tiny delay is no problem. PR to update the UX packages: symfony/ux#53 Cheers! Fixes #3 Commits ------- a9028b2 "fetch: lazy": don't download until the controller is present
|
Thanks Ryan. |
tgalopin
added a commit
to symfony/flex
that referenced
this pull request
Feb 2, 2021
… "fetch" mode (weaverryan) This PR was merged into the 1.9-dev branch. Discussion ---------- Changing to support next version of stimulus bridge with "fetch" mode Partner to symfony/stimulus-bridge#15 and symfony/ux#53 The tricky part about this is that, if the user has `stimulus-bridge` 1.x, then their `controllers.json` file needs `webpackMode`. If they have `stimulus-bridge` "next" (we're thinking it'll be 2.0), then their `controllers.json` file needs `fetch`. This means that Flex has a "hard break" and sorta just needs to assume that the user has the "new" version. We made the decision - to go from `webpackMode` to `fetch` because the setting no longer is truly the same as `webpackMode`. However, if we wanted to make the upgrade path easier, we could revert that and use `webpackMode` in 2.0 as well (instead of changing to `fetch`). Commits ------- 0c452b5 Changing to support next version of stimulus bridge with "fetch" mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
If symfony/stimulus-bridge#15 is merged, this updates the keys for all the UX packages.
The old
webpackModeis kept for now. This will prevent errors if you're using an "old" Flex version (a version before this PR symfony/flex#735). We can remove that... eventually...Cheers!