Skip to content

Incorrect image description for Session mode example #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Andre053 opened this issue May 30, 2023 · 2 comments
Open

Incorrect image description for Session mode example #802

Andre053 opened this issue May 30, 2023 · 2 comments

Comments

@Andre053
Copy link

Source: https://docs.syncthing.net/specs/relay-v1.html#id1

The Example Exchange caption references permanent and temporary protocol mode instead of session mode. Additionally, I think a deliminator between Client A and Client B descriptions would increase clarity. I propose a change to:

Client A - Session mode sender; Client B - Session mode receiver

Must add the deliminator to other descriptions for consistency.
@marbens-arch
Copy link
Member

Client A is more like Session mode race winner than anything. They both get a SessionInvitation at basically the same time, and then attempt to join the session.

@marbens-arch
Copy link
Member

marbens-arch commented Apr 14, 2025 •
edited
Loading

Looking at the "source code", it shows on the same line because of single newline instead of double newline.

marbens-arch added a commit to marbens-arch/syncthing-docs that referenced this issue Apr 14, 2025
@marbens-arch
fix(relay-v1): state that both A and B are in session mode (fixes syn…
902c8d3 
…cthing#802)

Permanent protocol and temporary protocol submodes don't exist in
session mode.
marbens-arch added a commit to marbens-arch/syncthing-docs that referenced this issue Apr 14, 2025
@marbens-arch @PanderMusubi
@acolomb @st-release @wgslr @systemcrash @swenske
Session mode example (#1)
cbd906f 
* chore(contrib): move syncthing-android and SyncTrayzor to old list (syncthing#895)

SyncTrayzor hasn't received any commits in 4 years, and
syncthing-android is officially discontinued, so add them to the old
list.

Fixes syncthing#892.

* chore(contrib): stop calling Syncthing-Fork an "alternative" (syncthing#896)

Co-authored-by: André Colomb <[email protected]>

* Update author list

* fix: word order in ignoring.rst (syncthing#897)

* Update author list

* fix(faq): update info about checking if a device is relaying (syncthing#899)

Devices now still show "Address", even if connected via a relay, so
we change the information to still be accurate.

The "address" that it shows refers to the address of the relay, if
connected via a relay.

* Update author list

* Update version list

* chore(config): simplify list of STUN servers (syncthing#902)

We're removing discontinued STUN servers in syncthing/syncthing#10012,
so we update the documentation accordingly, while simplifying.

* fix(config): update default `stunKeepaliveStartS` (syncthing#903)

Ever since syncthing/syncthing@e714df0,
`stunKeepaliveStartS` has defaulted to 180, and not 24.

* Update version list

* Update author list

* fix(strings): differentiate setup(n) and set(v) up (syncthing#905)

* Update author list

* chore(config): add MetricsWithoutAuth (syncthing#906)

syncthing/syncthing#10045

* fix(relay-v1): state that both A and B are in session mode (fixes syncthing#802)

Permanent protocol and temporary protocol submodes don't exist in
session mode.

---------

Co-authored-by: Pander <[email protected]>
Co-authored-by: André Colomb <[email protected]>
Co-authored-by: Syncthing Release Automation <[email protected]>
Co-authored-by: Wojciech Geisler <[email protected]>
Co-authored-by: Paul Donald <[email protected]>
Co-authored-by: Sébastien WENSKE <[email protected]>
marbens-arch added a commit to marbens-arch/syncthing-docs that referenced this issue Apr 21, 2025
@marbens-arch
fix(relay-v1): state that both A and B are in session mode (fixes syn…
284793d 
…cthing#802)

Permanent protocol and temporary protocol submodes don't exist in
session mode.
marbens-arch added a commit to marbens-arch/syncthing-docs that referenced this issue Apr 21, 2025
@marbens-arch
fix(relay-v1): state that both A and B are in session mode (fixes syn…
68573d9 
…cthing#802) (#2)

Permanent protocol and temporary protocol submodes don't exist in
session mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andre053 @marbens-arch