-
Notifications
You must be signed in to change notification settings - Fork 94
Expose the full AuthResponse details #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ls can be retrieved
My team hit a blocker where we need to be able to access some of the data in the We have a demo with our CVP early next week so I was hoping to get this in by the weekend if at all possible. |
jwtIdToken: idToken, | ||
account: authResponse.account, | ||
authenticationResponse: authResponse, | ||
jwtAccessToken: authResponse.accessToken, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the token data and account info already exists in the AuthResponse object, but I've elected to keep the previous values to prevent breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose
Currently we only expose the
Account
info when authentication completes. This is not sufficient because, for example, this would not give access to thestate
data which is needed for many security scenarios. The full authentication details are exposed bymsal
using theAuthResponse
, and we should be returning this data and storing in Redux.Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
AuthResponse
is saved in the Redux store asauthenticationResponse
using the React DevTools extension.