Skip to content

Fix to expose missing types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Fix to expose missing types #1

merged 1 commit into from
Feb 6, 2022

Conversation

nickrttn
Copy link
Contributor

@nickrttn nickrttn commented Feb 6, 2022

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This PR exposes the type declaration file in package.json, to make sure it is included in the published version of the package on NPM.

I've removed a @ts-expect-error directive in test.js where no error was being thrown by TS, except about the directive itself.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
nickrttn Nick Rutten
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 6, 2022
@ChristianMurphy ChristianMurphy added the ☂️ area/types This affects typings label Feb 6, 2022
@wooorm wooorm changed the title Expose type declaration files Fix to expose missing types Feb 6, 2022
@wooorm wooorm merged commit 0dbf7ad into syntax-tree:main Feb 6, 2022
@wooorm wooorm added the 💪 phase/solved Post is done label Feb 6, 2022
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Feb 6, 2022
@wooorm
Copy link
Member

wooorm commented Feb 6, 2022

Released, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants