-
-
Notifications
You must be signed in to change notification settings - Fork 4
Closed
Labels
☂️ area/typesThis affects typingsThis affects typings🐛 type/bugThis is a problemThis is a problem👶 semver/patchThis is a backwards-compatible fixThis is a backwards-compatible fix💪 phase/solvedPost is donePost is done📦 area/depsThis affects dependenciesThis affects dependencies
Description
Initial checklist
- I read the support docsI read the contributing guideI agree to follow the code of conductI searched issues and couldn’t find anything (or linked relevant results below)To pick up a draggable item, press the space bar. While dragging, use the arrow keys to move the item. Press space again to drop the item in its new position, or press escape to cancel.
Affected packages and versions
hast-util-raw@8.0.0 and hast-util-raw@9.0.0
Looks like the reference to @types/unist
was introduced in #17.
Link to runnable example
No response
Steps to reproduce
- Create project using
hast-util-raw
with a strict package manager like Yarn PnP andskipLibCheck
set tofalse
. - Type-check using TypeScript.
Expected behavior
No type errors.
Actual behavior
Type error:
ERROR in node_modules/hast-util-raw/lib/index.d.ts:28:28
TS2307: Cannot find module 'unist' or its corresponding type declarations.
26 | export type Location = import('parse5').Token.Location;
27 | export type TagToken = import('parse5').Token.TagToken;
> 28 | export type Point = import('unist').Point;
| ^^^^^^^
29 | export type VFile = import('vfile').VFile;
30 | /**
31 | * Configuration.
Affected runtime and version
N/A
Affected package manager and version
No response
Affected OS and version
No response
Build and bundle tools
No response
Metadata
Metadata
Assignees
Labels
☂️ area/typesThis affects typingsThis affects typings🐛 type/bugThis is a problemThis is a problem👶 semver/patchThis is a backwards-compatible fixThis is a backwards-compatible fix💪 phase/solvedPost is donePost is done📦 area/depsThis affects dependenciesThis affects dependencies
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
[-]Type error when using strict package managers[/-][+]Type error when using strict package manager[/+]remcohaszing commentedon Aug 28, 2023
You’re right, this should be an explicit dependency. Would you like to add a PR for this?
github-actions commentedon Aug 28, 2023
github-actions commentedon Aug 28, 2023
wooorm commentedon Aug 28, 2023
https://github.com/syntax-tree/hast-util-raw/releases/tag/9.0.1