Skip to content

Would love TypeScript types for this package #4

Closed
@chmac

Description

@chmac

Subject of the feature

I think this is the first unist-util package that typescript wants types for. So first and foremost, thanks for all the really useful code that's already out there, this stuff is making my life a whole hella lot easier!

Any chance of adding types to this package? I guess I'll do a quick and dirty any type for now as my package typing fu is not so strong. I'd be happy to support with a PR or some review if that's helpful. I'd need some pointers on the PR front, but if you could potentially point me at another repo which does have types, maybe I could copy the typing concepts into this one, or something like that. Will wait to hear back before diving into it.

Activity

ChristianMurphy

ChristianMurphy commented on Feb 6, 2020

@ChristianMurphy
Member

Any chance of adding types to this package?

It's on the list to add these,
there are over 300 repositories in syntax-tree + unified + remark + rehype + retext + redot, this isn't a repo we'd had a chance to add types to yet.

I'd be happy to support with a PR or some review if that's helpful. I'd need some pointers on the PR front, but if you could potentially point me at another repo which does have types, maybe I could copy the typing concepts into this one, or something like that.

Some examples to draw inspiration from
syntax-tree/hast-util-to-html#17
syntax-tree/unist-util-find-all-after#7
syntax-tree/mdast-util-toc#62
syntax-tree/unist-util-map#1
syntax-tree/unist-util-inspect#9
syntax-tree/unist-util-select#7
syntax-tree/unist-builder#3
syntax-tree/unist-util-filter#2

wooorm

wooorm commented on Mar 19, 2020

@wooorm
Member

Released in 2.0.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @chmac@wooorm@ChristianMurphy

      Issue actions

        Would love TypeScript types for this package · Issue #4 · syntax-tree/unist-util-modify-children