Skip to content

Add automatic, classic runtime types #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2021
Merged

Add automatic, classic runtime types #9

merged 2 commits into from
May 4, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented May 3, 2021 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Adds types for the runtimes in TypeScript

@wooorm wooorm added the ☂️ area/types This affects typings label May 3, 2021
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels May 3, 2021
@remcohaszing remcohaszing mentioned this pull request May 3, 2021
Open
@remcohaszing
Fix types of automatic and classic runtimes
401082d 
Closes GH-10.
Closes GH-11.

Reviewed-by: Christian Murphy <[email protected]>
Reviewed-by: Titus Wormer <[email protected]>
@wooorm wooorm marked this pull request as ready for review May 4, 2021 16:02
@ChristianMurphy ChristianMurphy changed the title wip: add automatic, classic runtime types add automatic, classic runtime types May 4, 2021
@wooorm wooorm changed the title add automatic, classic runtime types Add automatic, classic runtime types May 4, 2021
@wooorm wooorm merged commit 8f31c38 into main May 4, 2021
@wooorm wooorm deleted the runtime-types branch May 4, 2021 20:59
@github-actions github-actions bot added 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels May 4, 2021
@wooorm wooorm added 💪 phase/solved Post is done and removed 👎 phase/no Post cannot or will not be acted on 🤷 no/invalid This cannot be acted upon labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@remcohaszing remcohaszing Awaiting requested review from remcohaszing

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wooorm @ChristianMurphy @remcohaszing