Fix T2C in system simulation #593
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChinYikMing
reviewed
Apr 30, 2025
There was a problem hiding this comment.
Remove the ENABLE_T2C=0 option for macOS host as well.
rv32emu/.github/workflows/main.yml
Line 487 in 4ee642c
rv32emu/.github/workflows/main.yml
Line 489 in 4ee642c
ChinYikMing
reviewed
Apr 30, 2025
- Add MMU-related code in memory operation - Fix indirect branch handling
ChinYikMing
reviewed
May 1, 2025
| LLVMBuildCall2(*builder, mmu_fn_type, mmu_fn_ptr, params, 3, ""); \ | ||
| } | ||
|
|
||
| t2c_mmu_load_impl(lb, mmu_read_b, 8, true); |
There was a problem hiding this comment.
Shall we enforce capitalization for consistency (e.g., BRANCH_FUNC in the same file) in such function declarations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Bito
This pull request enhances the memory management unit (MMU) functionality and refines T2C operations by refactoring read/write processes and improving indirect branch handling. Key updates include modifications to the JIT cache structure for better key management, aimed at boosting performance and reliability in system simulations.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are focused and well-defined, making the review process straightforward.