-
-
Notifications
You must be signed in to change notification settings - Fork 2
Cleanup and comment improvements #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add per-line pseudo code style code comments to almost all inline assemblies. Hopefully this will make the code easier to understand for people who are not familiar with assembly. - Add module-level comments to some architectures describing the types of atomic instructions provided by that architecture. I plan to add this for other architectures in the future. - Clean up suboptimal or redundant code found during the above process. - Add links to generated assemblies for tier 3 targets.
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
taiki-e
added a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-aarch64
Target: Armv8-A, Armv8-R, or later processors in AArch64 mode
O-arm
Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
O-avr
Target: AVR
O-hexagon
Target: Qualcomm Hexagon
O-loongarch
Target: LoongArch
O-m68k
Target: Motorola 68000 series
O-mips
Target: MIPS processors
O-msp430
Target: MSP430
O-powerpc
Target: PowerPC processors
O-riscv
Target: RISC-V architecture
O-s390x
Target: SystemZ processors (s390x)
O-x86
Target: x86/x64 processors
O-xtensa
Target: Xtensa processors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add per-line pseudo code style code comments to almost all inline assemblies.
Hopefully this will make the code easier to understand for people who are not familiar with assembly.
For example:
atomic-maybe-uninit/src/arch/powerpc.rs
Lines 187 to 192 in d901983
Add module-level comments to some architectures describing the types of atomic instructions provided by that architecture. I plan to add this for other architectures in the future.
UPDATE: this now extended to more architectures as "Atomic operation overview by architecture". See the linked docs for more.
Clean up suboptimal or redundant code found during the above process.
Add links to generated assemblies for tier 3 targets.