-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Accept config as a JS object #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, also sorry for the three commits. I pushed each commit immediately after creating it, so I am not sure how I could squash them? |
tailwind's configuration file exports the configuration, why can't you just merge the user config with the exported tailwind setup? |
@phroggyy Yes, I'm doing that. But then there was no way to pass that merged config object to Tailwind, because it only accepted a path to a file. I could write it to a temporary file, but it seems like a better solution to make Tailwind accept either a file or an object. |
Hey @benface any chance you can update this PR or resubmit without the package-lock.json changes? |
Sure thing @adamwathan, done in #508 |
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request. ### What changed? #### ✳️ enhanced-resolve (5.18.2 → 5.18.3) · [Repo](https://github.com/webpack/enhanced-resolve) <details> <summary>Release Notes</summary> <h4><a href="https://github.com/webpack/enhanced-resolve/releases/tag/v5.18.3">5.18.3</a></h4> <blockquote><h3 dir="auto">Fixes</h3> <ul dir="auto"> <li>Fixed nonsensible intersection in types</li> </ul> <h3 dir="auto">Performance</h3> <ul dir="auto"> <li>Decreased initial loading time</li> </ul></blockquote> <p><em>Does any of this look wrong? <a href="https://depfu.com/packages/npm/enhanced-resolve/feedback">Please let us know.</a></em></p> </details> <details> <summary>Commits</summary> <p><a href="https://github.com/webpack/enhanced-resolve/compare/0bf45033f4cb12e034819c4e420ca12965619fc8...52b61d0f0318318a6e5b3e8c905c887824f9303a">See the full diff on Github</a>. The new version differs by 5 commits:</p> <ul> <li><a href="https://github.com/webpack/enhanced-resolve/commit/52b61d0f0318318a6e5b3e8c905c887824f9303a"><code>chore(release): 5.18.3</code></a></li> <li><a href="https://github.com/webpack/enhanced-resolve/commit/ec38ca98517a1eaac259a67e2d31ebd8695f4c65"><code>perf: decrease initial loading time (#458)</code></a></li> <li><a href="https://github.com/webpack/enhanced-resolve/commit/5f74295eacf02b2c5296cff577c6a8fbd5bcb2c2"><code>refactor: update eslint config (#457)</code></a></li> <li><a href="https://github.com/webpack/enhanced-resolve/commit/86ff2125e929a28e95b08e9b902f9da0ce941a7b"><code>fix(types): fix nonsensible intersection</code></a></li> <li><a href="https://github.com/webpack/enhanced-resolve/commit/367d0f65e6f76df763c9d04ff0fe38fcc168ddc0"><code>chore(deps): bump form-data from 3.0.3 to 3.0.4 (#455)</code></a></li> </ul> </details> ---  [Depfu](https://depfu.com) will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with `@depfu rebase`. <details><summary>All Depfu comment commands</summary> <blockquote><dl> <dt>@depfu rebase</dt><dd>Rebases against your default branch and redoes this update</dd> <dt>@depfu recreate</dt><dd>Recreates this PR, overwriting any edits that you've made to it</dd> <dt>@depfu merge</dt><dd>Merges this PR once your tests are passing and conflicts are resolved</dd> <dt>@depfu cancel merge</dt><dd>Cancels automatic merging of this PR</dd> <dt>@depfu close</dt><dd>Closes this PR and deletes the branch</dd> <dt>@depfu reopen</dt><dd>Restores the branch and reopens this PR (if it's closed)</dd> <dt>@depfu pause</dt><dd>Ignores all future updates for this dependency and closes this PR</dd> <dt>@depfu pause [minor|major]</dt><dd>Ignores all future minor/major updates for this dependency and closes this PR</dd> <dt>@depfu resume</dt><dd>Future versions of this dependency will create PRs again (leaves this PR as is)</dd> </dl></blockquote> </details> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
This feature was previously discussed here: tailwindlabs/discuss#37
I needed this for a custom gulp build script where the user is able to override parts of the Tailwind config using a JSON file, so the final config is built dynamically rather than contained in a single file. I am not sure if I implemented it properly, as I didn't take the time to go deep in the codebase, but this worked for me and all the tests passed. I'm sorry if I missed anything; if so please let me know. Also I imagine it would be a good idea to add a test for this feature.