Skip to content

Raise error for select with space without indexes #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AnaNek opened this issue Feb 9, 2022 · 0 comments · Fixed by #258
Closed

Raise error for select with space without indexes #257

AnaNek opened this issue Feb 9, 2022 · 0 comments · Fixed by #258
Assignees
@AnaNek
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@AnaNek
Copy link
Contributor

AnaNek commented Feb 9, 2022

When select() is called for space with no indexes select
fails with error crud/crud/select/plan.lua:22: attempt to index local 'index' (a nil value)
@AnaNek AnaNek self-assigned this Feb 9, 2022
AnaNek added a commit that referenced this issue Feb 9, 2022
@AnaNek
Fix fail of select when there are no indexes in space
22aaa76 
When `select()` is called for space with no indexes `select`
fails with error `attempt to index local 'index' (a nil value)`.
This fix checks if space contains indexes and if there are
no indexes in space `select` returns error
`Space has no indexes,space should have primary and bucket_id indexes`.

Closes #257
@AnaNek AnaNek mentioned this issue Feb 9, 2022
Merged
@Totktonada Totktonada added 1sp code health Improve code readability, simplify maintenance and so on labels Feb 9, 2022
AnaNek added a commit that referenced this issue Feb 15, 2022
@AnaNek
Fix fail of select when there are no indexes in space
b71e98d 
When `select()` is called for space with no indexes `select`
fails with error `attempt to index local 'index' (a nil value)`.
This fix checks if space contains indexes and if there are
no indexes in space `select` returns error
`Space has no indexes,space should have primary and bucket_id indexes`.

Closes #257
AnaNek added a commit that referenced this issue Feb 15, 2022
@AnaNek
Fix fail of select when there are no indexes in space
5a154db 
When `select()` is called for space with no indexes `select`
fails with error `attempt to index local 'index' (a nil value)`.
This fix checks if space contains indexes and if there are
no indexes in space `select` returns error
`Space has no indexes,space should have primary and bucket_id indexes`.

Closes #257
AnaNek added a commit that referenced this issue Feb 16, 2022
@AnaNek
Fix fail of select when there are no indexes in space
47e5955 
When `select()` is called for space with no indexes `select`
fails with error `attempt to index local 'index' (a nil value)`.
This fix checks if space contains indexes and if there are
no indexes in space `select` returns error
`NoIndexesError:new('Space %q has no indexes, space should have primary index', space_name)`.

Closes #257
Totktonada pushed a commit that referenced this issue Feb 17, 2022
@AnaNek @Totktonada
Fix fail of select when there are no indexes in space
842b30a 
When `select()` is called for space with no indexes `select`
fails with error `attempt to index local 'index' (a nil value)`.
This fix checks if space contains indexes and if there are
no indexes in space `select` returns error
`NoIndexesError:new('Space %q has no indexes, space should have primary index', space_name)`.

Closes #257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaNek AnaNek

Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fail of select when there are no indexes in space tarantool/crud
2 participants
@Totktonada @AnaNek