Write in log when see `select(nil)` #276

kyukhin · 2022-04-21T10:15:33Z

After internal discussion, we decided:

Warn the user about potentially dangerous code
With logging level - CRIT
For all cases:
- crud:select()
- crud:select(nil)
- crud:select{}
With ratelimit (it's worth raising it higher than 0.5 sec for this particular case)
Add the option fullscan=true to suppress the message in the log

The text was updated successfully, but these errors were encountered:

Totktonada · 2022-04-24T21:40:57Z

How it is implemented in tarantool: tarantool/tarantool#7064. (At the moment of writing this, the pull request is in review and things may change.)

Empty or nil select calls on user spaces tend to be dangerous. To mitigate this, a critical log entry containing the current stack traceback is created upon such function calls — a user can explicitly request a full scan though by passing fullscan = true to select's options table argument in which a case a log entry will not be created. Closes #276

Empty or nil select calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon empty or nil select calls — a user can explicitly request a full scan though by passing fullscan = true to select's options table argument in which a case a log entry will not be created. Tarantool has a similar implementation[1]. 1. tarantool/tarantool#7064 Closes #276

oleg-jukovec · 2022-05-13T08:48:29Z

Requirements have been updated:

tarantool/tarantool#7129

Unlimited select calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon unlimited select calls — a user can explicitly request a full scan though by passing fullscan = true to select's options table argument in which a case a log entry will not be created. Tarantool has a similar implementation[1]. 1. tarantool/tarantool#7064 Closes #276

Unlimited select calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon unlimited select calls — a user can explicitly request a full scan though by passing fullscan = true to select's options table argument in which a case a log entry will not be created. Tarantool has a similar implementation[1]. 1. tarantool/tarantool#7064 Part of #276

Unlimited count calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon unlimited count calls — a user can explicitly request a full scan though by passing fullscan = true to count's options table argument in which a case a log entry will not be created. Closes #276

Potentially long select calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon potentially long select calls — a user can explicitly request a full scan though by passing fullscan = true to select's options table argument in which a case a log entry will not be created. Tarantool has a similar implementation[1][2]. 1. tarantool/tarantool#7064 2. tarantool/tarantool#7131 Part of #276

Potentially long count calls on user spaces tend to be dangerous. A critical log entry containing the current stack traceback is created upon potentially long count calls — a user can explicitly request a full scan though by passing fullscan = true to count's options table argument in which a case a log entry will not be created. Closes #276