Fix merger support recognition on tarantool 2.10+ #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
commented
Oct 19, 2021
Totktonada
force-pushed
the
Totktonada/fix-tarantool-2-10-determination
branch
from
68ebfdc to
d32f401
Compare
3 tasks
Totktonada
force-pushed
the
Totktonada/fix-tarantool-2-10-determination
branch
3 times, most recently
from
f12b490 to
82a0518
Compare
We cannot use just string comparison as before, because '2.10.0-<...>'
less than, say, '2.3' lexicographically. The module had to use the old
select implementation on tarantool 2.10 due to this problem.
Implemented more accurate checks, whether built-in and external
tuple-merger are supported. Say, it'll not enable the built-in merger on
tarantool 2.4.1, where the module has a known problem (see comments in
the code).
Fixed the problem of the same kind in a test case.
When I replaced `_G._TARANTOOL` with just `_TARANTOOL`, the luacheck
linter said me:
| <...>/test/helper.lua:307:31: accessing undefined field match of
| global _TARANTOOL
On the line:
| local major_minor_patch = _TARANTOOL:split('-', 1)[1]
But when I added '_TARANTOOL' into globals, it stops to complain.
Strange, but okay. I prefer just `_TARANTOOL` without `_G`.
olegrok
approved these changes
Nov 13, 2021
Totktonada
added a commit
that referenced
this pull request
Nov 16, 2021
* Fixed the incorrect JSON path indexes check (it was introduced in 2.1.2). * Properly commented all checks. * Correctly handle `tarantool-3*`, `tarantool-4*` and so on. * Normalized as DNF for readability. It follows changes I made in PR #227 for merger checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use just string comparison as before, because '2.10.0-<...>'
less than, say, '2.3' lexicographically. The module had to use the old
select implementation on tarantool 2.10 due to this problem.
Implemented more accurate checks, whether built-in and external
tuple-merger are supported. Say, it'll not enable the built-in merger on
tarantool 2.4.1, where the module has a known problem (see comments in
the code).
Fixed the problem of the same kind in a test case.