-
Notifications
You must be signed in to change notification settings - Fork 15
Make CRUD select error message more clearer. #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CRUD select error message more clearer. #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be LGTM after fixing some minor things:
- please, squash commits and make them more informative (see doc 1 and doc 2, repo commit messages as an example);
- I think it's worth to add a CHANGELOG entry
5388c0c
to
d20b55b
Compare
0158fcd
to
9fbb70b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. Should be LGTM after resolving remaining minor things]
9fbb70b
to
1d587f4
Compare
1d587f4
to
8f3cea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after last fix and rebase onto master
8f3cea3
to
82c5ad2
Compare
Report "crud is not initialized" error if storage functions are not defined. Before this patch, select error description does not give any clues about possible causes of undefined storage functions. Part of #229
82c5ad2
to
6d57151
Compare
There is a difference between error description for select and other CRUD calls in case of CRUD storage unavailability.
The select error description does not give any clues what might be the cause of this error.
Here is the updated error text:
The new error description for select also contains information about replicaset id.
Additionally, nil replicaset id is fixed in error messages for single calls: get, delete, etc.
See also #229