Skip to content

ci: bump ubuntu version #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patapenka-alexey
Copy link
Contributor

@patapenka-alexey patapenka-alexey commented Apr 3, 2025

Bump actions to use ubuntu-24.04 for fixing the following GitHub warning:

The Ubuntu 20.04 Actions runner image will begin deprecation
on 2025-02-01.

Update list of tarantool versions to test.

Part of #TNTP-1918

@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 7 times, most recently from 1b3c666 to fae3e4c Compare April 3, 2025 11:52
@patapenka-alexey patapenka-alexey marked this pull request as ready for review April 3, 2025 11:53
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from ae77ce1 to 41fc7c0 Compare April 3, 2025 12:28
@patapenka-alexey patapenka-alexey requested a review from elhimov April 3, 2025 19:04
Copy link

@elhimov elhimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the coverity issue. Need more confident and qualified answer.

@@ -66,6 +61,7 @@ jobs:

- name: Run tests and code coverage analysis
run: make -C build coverage
if: ${{ matrix.tarantool != '3.3' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if: ${{ matrix.tarantool != '3.3' }}
if: ${{ matrix.tarantool == '3.3' }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to matrix.coveralls

@oleg-jukovec oleg-jukovec self-requested a review April 4, 2025 15:37
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from 214104c to 15a4af3 Compare April 7, 2025 08:50
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from f496f37 to 582eb9b Compare April 7, 2025 11:53
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 2 times, most recently from 77cf5be to 2256eda Compare April 8, 2025 06:38
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from f1a1f44 to ce9a2c7 Compare April 8, 2025 07:16
Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:

    The Ubuntu 20.04 Actions runner image will begin deprecation
    on 2025-02-01.

Update list of `tarantool` versions to test.

Part of #TNTP-1918
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from ae5cab9 to 19965a6 Compare April 8, 2025 07:38
@oleg-jukovec oleg-jukovec merged commit 3956257 into master Apr 8, 2025
6 checks passed
@oleg-jukovec oleg-jukovec deleted the patapenka-alexey/tntp-1918-bump-ubuntu-version branch April 8, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants