datetime_object: specify supported iso8601 formats #3155

TarantoolBot · 2022-09-19T12:43:41Z

Related dev. issue(s): https://github.com/tarantool/tarantool/pull/6731/files#r829826291

Product: Tarantool
Since: 2.10
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/datetime/datetime_object/#datetime-parse
SME: @ tsafin @ ligurio

Details

<…>ime information.
format (string) – indicator of the input_sting |format|. Possible values: ‘iso8601’, ‘rfc3339’, or strptime-like format<…>

https://www.tarantool.io/en/doc/latest/reference/reference_lua/datetime/datetime_object/#datetime-parse

We don't support all possible iso8601 formats, see discussion in https://github.com/tarantool/tarantool/pull/6731/files#r829826291

Definition of done

the reference contains clear and precise information about supported datetime formats

ligurio · 2024-07-31T18:59:46Z

See also:

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. Supported formats must be added to the testing and the patch do it. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Needed for tarantool/doc#3155 NO_CHANGELOG=testing NO_DOC=tarantoolgh-3155

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. Supported formats must be added to the testing and the patch do it. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantoolgh-3155

Closes #3155

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. Supported formats must be added to the testing and the patch do it. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantool/doc#3155

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. The patch adds a tests for most of supported formats. The tests were created using a page about date and time formats in ISO 8601 and RFC 3339 standards [2] and these tests are not exhaustive. More thorough testing can be done with property-based testing and randomization. It will be a subject of the following commits. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Follows up tarantool#6731 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantool/doc#3155

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. The patch adds a tests for most of supported formats. The tests were created using a page about date and time formats in ISO 8601 and RFC 3339 standards [2] and these tests are not exhaustive. More thorough testing can be done with property-based testing and randomization. It will be a subject of the following commits. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Follows up #6731 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantool/doc#3155

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. The patch adds a tests for most of supported formats. The tests were created using a page about date and time formats in ISO 8601 and RFC 3339 standards [2] and these tests are not exhaustive. More thorough testing can be done with property-based testing and randomization. It will be a subject of the following commits. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Follows up tarantool#6731 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantool/doc#3155 (cherry picked from commit dcb1963)

The commit 3c40366 ("datetime, lua: date parsing functions") introduced a function `datetime.parse()`. The function accepts a datetime format: 'iso8601', 'rfc3339' and a custom datetime format. However, 'iso8601' as well as 'rfc3339' is a set of datetime formats (see [1] and [2]), and `datetime.parse()` supports a subset of these formats. There is a documentation issue [3], where we should describe what formats are supported and what formats are not. The patch adds a tests for most of supported formats. The tests were created using a page about date and time formats in ISO 8601 and RFC 3339 standards [2] and these tests are not exhaustive. More thorough testing can be done with property-based testing and randomization. It will be a subject of the following commits. 1. https://datatracker.ietf.org/doc/html/rfc3339 2. https://ijmacd.github.io/rfc3339-iso8601/ 3. tarantool/doc#3155 Follows up #6731 Needed for tarantool/doc#3155 Co-authored-by: Sergey Kaplun <[email protected]> NO_CHANGELOG=testing NO_DOC=tarantool/doc#3155 (cherry picked from commit dcb1963)

p7nov added this to the Estimate [@p7nov] milestone Sep 22, 2022

p7nov added 2sp datetime reference [location] Tarantool manual, Reference part labels Sep 22, 2022

p7nov changed the title ~~feedback: datetime_object | Tarantool~~ datetime_object: specify supported iso8601 formats Sep 22, 2022

p7nov added 3sp 2.10 and removed 2sp labels Sep 22, 2022

p7nov removed this from the Estimate [@p7nov] milestone Sep 22, 2022

veod32 removed the 3sp label Dec 9, 2022

ligurio mentioned this issue Aug 1, 2024

datetime: test RFC 3339 and ISO 8601 formats tarantool/tarantool#10348

Merged

ligurio added a commit that referenced this issue Aug 12, 2024

datetime: add a note ragarding supported formats

8b5e9da

Closes #3155

ligurio mentioned this issue Aug 12, 2024

datetime: add a note regarding supported formats #4426

Merged

ligurio added a commit that referenced this issue Aug 12, 2024

datetime: add a note about supported formats

37b4364

Closes #3155

ligurio added a commit that referenced this issue Aug 12, 2024

datetime: add a note about supported formats

5ad79d0

Closes #3155

andreyaksenov closed this as completed in #4426 Aug 12, 2024

andreyaksenov pushed a commit that referenced this issue Aug 12, 2024

datetime: add a note about supported formats (#4426)

dbee43e

Closes #3155

ligurio mentioned this issue Aug 14, 2024

[Backport 2.11] datetime: test RFC 3339 and ISO 8601 formats tarantool/tarantool#10409

Merged

ligurio mentioned this issue Aug 14, 2024

[Backport 3.1] datetime: test RFC 3339 and ISO 8601 formats tarantool/tarantool#10410

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

datetime_object: specify supported iso8601 formats #3155

datetime_object: specify supported iso8601 formats #3155

TarantoolBot commented Sep 19, 2022 •

edited by p7nov

Loading

ligurio commented Jul 31, 2024

Uh oh!

datetime_object: specify supported iso8601 formats #3155

datetime_object: specify supported iso8601 formats #3155

Comments

TarantoolBot commented Sep 19, 2022 • edited by p7nov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Definition of done

ligurio commented Jul 31, 2024

Uh oh!

TarantoolBot commented Sep 19, 2022 •

edited by p7nov

Loading