Skip to content

feedback: Submodule box.index #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TarantoolBot opened this issue Jul 12, 2019 · 4 comments · Fixed by #883
Closed

feedback: Submodule box.index #825

TarantoolBot opened this issue Jul 12, 2019 · 4 comments · Fixed by #883
Assignees
Labels
need feedback [special status] On hold, awaiting feedback

Comments

@TarantoolBot
Copy link
Collaborator

<…>
name: primary
type: TREE
...

index_object:pairs([key**|[, iterator-type]|])**
Search for a tuple or a set of tuples via the given index,
an<…>

https://www.tarantool.io/en/doc/1.10/book/box/box_index/#box-index-index-pairs

[, opts = {}]

@izmalk
Copy link
Contributor

izmalk commented Jul 24, 2019

Shouldn't we just use [, iterator={iterator_type}] instead?

@izmalk izmalk added the need feedback [special status] On hold, awaiting feedback label Jul 25, 2019
@lenkis
Copy link
Contributor

lenkis commented Aug 7, 2019

please double-check with @Totktonada

@Totktonada
Copy link
Member

Why not to check it myself?

box.cfg{}
box.schema.create_space('s')
box.space.s:create_index('pk')
box.space.s:insert({1})
box.space.s:insert({2})
box.space.s:insert({3})
for _, tuple in box.space.s:pairs(nil, {iterator = box.index.REQ}) do print(require('json').encode(tuple)) end
for _, tuple in box.space.s:pairs(nil, {iterator = 'REQ'}) do print(require('json').encode(tuple)) end
for _, tuple in box.space.s:pairs(nil, box.index.REQ) do print(require('json').encode(tuple)) end
for _, tuple in box.space.s:pairs(nil, 'REQ') do print(require('json').encode(tuple)) end

@izmalk
Copy link
Contributor

izmalk commented Aug 15, 2019

Thanks for the feedback and examples. Variant №3 seems to cause error. Since №1 and 2 are working well i think it will be best to change the documentation to [, iterator={iterator_type}] syntax instead of [, iterator-type].

izmalk pushed a commit that referenced this issue Aug 15, 2019
izmalk pushed a commit that referenced this issue Aug 15, 2019
Fixed iterator-type parameter syntax scheme
@izmalk izmalk closed this as completed Aug 22, 2019
lenkis pushed a commit that referenced this issue Sep 2, 2019
Fix gh-825 feedback: Submodule box.index
Fix gh-857 feedback: Модель данных
Fix gh-856 feedback: Access control
Fix gh-853 feedback: Functions for transaction management
Fix gh-848 feedback: Submodule box.index
Fix gh-834 Использование бинарного пакета
Fix gh-867 feedback: Access control
Fix gh-866 feedback: Триггеры
Fix gh-865 feedback: Триггеры
Fix gh-864 feedback: Рекомендации по Lua-синтаксису
Fix gh-861 feedback: Модуль http
Fix gh-869 Сonfusing wording in box.backup page
Fix gh-860 vshard.router/storage.sync miss return value documentation
Fix gh-830 Improve documentation on fibers
Fix gh-850 Add more info about connectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need feedback [special status] On hold, awaiting feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants