Skip to content

feedback: Module fiber #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TarantoolBot opened this issue Jul 17, 2019 · 3 comments
Closed

feedback: Module fiber #831

TarantoolBot opened this issue Jul 17, 2019 · 3 comments
Assignees
@v-izmalkov
Labels
need feedback [special status] On hold, awaiting feedback

Comments

@TarantoolBot
Copy link
Collaborator

<…>d

  • error: fiber is cancelled
    ...

fiber.testcancel()
|Check if the current fiber has been cancelled
and throw an exception if this is the case.|
Example:

fiber.testcancel()tarantool> fiber.testcancel()
---<…>

https://www.tarantool.io/en/doc/1.10/reference/reference_lua/fiber/#fiber-testcancel

Нужно добавить, что ошибку, которую бросает вызов fiber.testcancel(), нельзя перехватить с помощью pcall и xpcall.
@izmalk izmalk closed this as completed in 1768dbc Aug 7, 2019
izmalk added a commit that referenced this issue Aug 7, 2019
@izmalk
Fix minor bugs (feedback tickets) (#854)
9f066eb 
* Fixed gh-797 feedback: SQL DBMS Modules
* Fixed gh-808 feedback: Lua tutorials
* Fixed gh-792 feedback: Модель данных
* Partial fix gh-804 feedback: Module digest Fixed only in English version!
* Fixed gh-796 feedback: Module net.box
* Fixed gh-810 feedback: Модуль string
* FIxed gh-821 feedback: Использование Docker-образа and quotes in the entire section
* Fixed gh-831 feedback: Module fiber

#831 Note added

* Fix #832

#832 Fixed typo - excessive module word at the end (one more generated by :ref: link).

* Fix #835

#835 Fixed typo

* Fix#791

#791 Add fuzzy to fix the list rendering

* #796 fixed markup issue

#796 **nil** instead of Nil

* Fixed quote marks as in #821

#821 (comment)

* Fixed term in fix #797

Fixed placeholder term #797

* Fix #841

#841 Fixed Russian translation

* Fix #845

#845 Fixed a typo
@Totktonada
Copy link
Member

Don't sure, to be honest, whether it is correct behaviour and what is cause of it.

@izmalk izmalk reopened this Aug 8, 2019
@lenkis lenkis closed this as completed in f93253f Aug 9, 2019
@Totktonada Totktonada reopened this Aug 9, 2019
izmalk pushed a commit that referenced this issue Aug 20, 2019
Fix gh-830
f757ca2 
Summirized the cancelled status issues in one NOTE and changed an example in fiber:cancel() description.
Also depended with #831  and #829
@izmalk izmalk added the need feedback [special status] On hold, awaiting feedback label Aug 23, 2019
@izmalk
Copy link
Contributor

izmalk commented Sep 3, 2019

Further improvements on documentation required regarding this issue - work in progress.

@lenkis lenkis assigned v-izmalkov and unassigned izmalk Sep 6, 2019
@Totktonada
Copy link
Member

It seems that the incorrect sentence

This exception cannot be caught by pcall or xpcall.

was fixed in b9ee8bb.

I propose to close this issue and open a new one if some futher work is needed on another parts of the article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-izmalkov v-izmalkov

Labels
need feedback [special status] On hold, awaiting feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Totktonada @TarantoolBot @izmalk @v-izmalkov