Skip to content

Make each function a link #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kostja opened this issue Jul 26, 2019 · 3 comments
Closed

Make each function a link #842

kostja opened this issue Jul 26, 2019 · 3 comments
Assignees
@Onvember
Labels
sql [location] SQL manual

Comments

@kostja
Copy link
Contributor

kostja commented Jul 26, 2019

https://www.tarantool.io/ru/doc/2.1/reference/reference_sql/sql/#functions is a link to all functions, but it's impossible to get a link on individual function
@lenkis lenkis added the 2.1 label Aug 1, 2019
izmalk pushed a commit that referenced this issue Aug 20, 2019
Fix gh-842 Make each function a link
ef76b88 
Made each separate function linkable. Plus some styling, decoration, refactoring.
@izmalk izmalk added the need feedback [special status] On hold, awaiting feedback label Aug 20, 2019
@izmalk izmalk closed this as completed Aug 23, 2019
@izmalk izmalk mentioned this issue Sep 2, 2019
Merged
lenkis added a commit that referenced this issue Sep 2, 2019
@lenkis
Multiple bug fixes version 2.1 specific
4746428 
Fix gh-847 feedback: Модуль json
Fix gh-853 feedback: Functions for transaction management
Fix gh-842 Make each function a link
@lenkis lenkis reopened this Sep 2, 2019
@lenkis
Copy link
Contributor

lenkis commented Sep 2, 2019

@izmalk Now that you added all labels, please make sure we make use of them in refs throughout the manual.

@lenkis lenkis assigned v-izmalkov and unassigned izmalk Sep 6, 2019
@v-izmalkov
Copy link
Contributor

I have failed to find any reliable evidence that they are ever used in our manual. All search results are false-positive or contain only pages SQL - a table with SQL standard features and SQL statements and clauses - an initial reference page with the labels i supposed to add links too.
Please advice

@lenkis
Copy link
Contributor

lenkis commented Oct 29, 2019

Please search 2 files (SQL reference https://www.tarantool.io/en/doc/2.2/reference/reference_sql/sql/#char and SQL user guide https://www.tarantool.io/en/doc/2.2/book/sql/) for each function's name. For example, CHAR function (https://www.tarantool.io/ru/doc/2.2/reference/reference_sql/sql/#char) is referred to from UNCODE function (https://www.tarantool.io/ru/doc/2.2/reference/reference_sql/sql/#unicode).

And please add labels/check links to aggregate functions, too: https://www.tarantool.io/en/doc/2.2/reference/reference_sql/sql/#aggregate-functions

@lenkis lenkis assigned Onvember and unassigned lenkis and v-izmalkov Oct 29, 2019
@lenkis lenkis added sql [location] SQL manual and removed need feedback [special status] On hold, awaiting feedback labels Oct 29, 2019
Onvember added a commit that referenced this issue Oct 30, 2019
@Onvember
Fixes gh-842
cb2b660
@lenkis lenkis mentioned this issue Oct 31, 2019
Merged
lenkis added a commit that referenced this issue Oct 31, 2019
@lenkis
Fixes gh-842, gh-914, gh-919, gh-958 by onvember (#969)
3ff14f8 
Fixes gh-842 Make each function a link
Fixes gh-914 Module string
Fixes gh-919 Update index definition description
Fixes gh-958 Module utf8
@lenkis lenkis closed this as completed Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Onvember Onvember

Labels
sql [location] SQL manual
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kostja @lenkis @Onvember @izmalk @v-izmalkov