-
Notifications
You must be signed in to change notification settings - Fork 43
msgpack.NULL is not nil! #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As I already said I think it should be cdata. @kyukhin right? |
|
The table shows msgpack and lua types and also has a colon that shows examples of a Lua value. msgpack nil type has the only value: Let's verify Lua -> msgpack mapping:
Let's verify msgpack -> Lua mapping:
So, yep, box.NULL (msgpack.NULL) is symmetric here, but I don't think that it would be wrong to give nil value as an example. Anyway, Mike asks to add a type (cdata) to the column with values examples. I don't understood a motivation of this request. It at least would not be consistent: some examples would be types, some would be values. @msiomkin Am I missed something? |
@Totktonada "Lua type" column contains types, not values. "bin" and "array" MsgPack types map to "cdata". Why not also map msgpack.NULL to "cdata" if |
I guess, @msiomkin proposes to document this:
I.e. state it clearly, that |
* Provide links to Lua and LuaJIT data types Resolves #1318 * Replace wrong link to Lua 5.2 with correct to Lua 5.1 Resolves #1321 * Provide a more relevant link to Lua table manual Resolves #1785 * Add msgpack.NULL to data types table Resolves #927 * Add a sharded space example Resolves #2474 * Clarify box.cfg.listen value type Resolves #2855
https://www.tarantool.io/en/doc/2.2/book/box/data_model/#lua-vs-msgpack
This table maps msgpack.NULL to Lua nil. It's wrong. I think there should be cdata type.
The text was updated successfully, but these errors were encountered: