Skip to content

Fix gh-1457 fix bug + add cookbook recipe for select-all #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2020
Merged

Fix gh-1457 fix bug + add cookbook recipe for select-all #1540

merged 4 commits into from
Sep 21, 2020

Conversation

lenkis
Copy link
Contributor

@lenkis lenkis commented Sep 11, 2020

No description provided.

@lenkis lenkis requested a review from dokshina September 11, 2020 13:58
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
doc/book/app_server/cookbook.rst
select_all.go
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In Go, there is no one-liner to select all tuples from a Tarantool space.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to explain that selecting all tuples is not a good idea not only in Go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To discuss with @artur-barsegyan.

dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 14, 2020
View reviewed changes
Copy link

@dokshina dokshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, pay attention to suggested changes. I think, it's better to call log.Fatalf than panic, but there is no big difference for cookbook snippet.

olegrok
olegrok reviewed Sep 14, 2020
View reviewed changes
olegrok
olegrok reviewed Sep 14, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 18, 2020
View reviewed changes
dokshina
dokshina reviewed Sep 18, 2020
View reviewed changes
@lenkis lenkis merged commit d9a1e72 into 1.10 Sep 21, 2020
lenkis added a commit that referenced this pull request Sep 21, 2020
@lenkis
Fix gh-1457 Go get started: fix bugs + add cookbook recipe for select…
8046b6e 
…-all (#1540)

(cherry picked from commit d9a1e72)
lenkis added a commit that referenced this pull request Sep 21, 2020
@lenkis
Fix gh-1457 Go get started: fix bugs + add cookbook recipe for select…
5b02418 
…-all (#1540)

(cherry picked from commit d9a1e72)
lenkis added a commit that referenced this pull request Sep 21, 2020
@lenkis
Fix gh-1457 Go get started: fix bugs + add cookbook recipe for select…
3419707 
…-all (#1540)

(cherry picked from commit d9a1e72)
lenkis added a commit that referenced this pull request Sep 21, 2020
@lenkis
Fix gh-1457 Go get started: fix bugs + add cookbook recipe for select…
3298367 
…-all (#1540)

(cherry picked from commit d9a1e72)
@NickVolynkin NickVolynkin deleted the lenkis/gh-1457-go branch February 5, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegrok olegrok olegrok left review comments

@dokshina dokshina dokshina left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenkis @olegrok @dokshina