Skip to content

Add iproto requests for stream transactions #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 7, 2022
Merged

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Jun 3, 2022

Resolves #2402 #2922

@p7nov p7nov marked this pull request as draft June 3, 2022 10:35
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 3, 2022 10:37 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 6, 2022 05:49 Inactive
@p7nov p7nov requested a review from locker June 6, 2022 05:56
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 6, 2022 09:27 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 6, 2022 10:56 Inactive
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 6, 2022 11:24 Inactive
@p7nov p7nov requested a review from locker June 6, 2022 11:37
@p7nov p7nov marked this pull request as ready for review June 6, 2022 12:04
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read committed, but not confirmed changes
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read only confirmed changes
- ``TXN_ISOLATION_BEST_EFFORD = 3`` -- determine isolation level automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: efford -> effort

@p7nov p7nov requested a review from patiencedaur June 6, 2022 12:25
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 6, 2022 12:26 Inactive
@p7nov p7nov changed the title Add IPROTO_TIMEOUT constant Add iproto requests for stream transactions Jun 7, 2022
@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 7, 2022 05:33 Inactive
Comment on lines +745 to +748
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value)
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value)
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically
- ``TXN_ISOLATION_DEFAULT = 0`` -- use the global default level (default value).
- ``TXN_ISOLATION_READ_COMMITTED = 1`` -- read changes that are committed but not confirmed yet.
- ``TXN_ISOLATION_READ_CONFIRMED = 2`` -- read confirmed changes.
- ``TXN_ISOLATION_BEST_EFFORT = 3`` -- determine isolation level automatically.

You can find the list punctuation rules in our style guide.

@github-actions github-actions bot temporarily deployed to branch-gh-2402-iproto-timeout June 7, 2022 06:46 Inactive
@p7nov p7nov merged commit d84a9d9 into latest Jun 7, 2022
@p7nov p7nov deleted the gh-2402-iproto-timeout branch June 7, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pt] ability to set timeout for iproto transactions was implemented
3 participants