Document IPROTO watchers #3044
Merged
Document IPROTO watchers #3044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
branch-gh-2408-iproto-watchers
github-actions
bot
temporarily deployed
to
branch-gh-2408-iproto-watchers
xuniq
force-pushed
the
gh-2408-iproto-watchers
branch
from
62901e5 to
93cd850
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2408-iproto-watchers
github-actions
bot
temporarily deployed
to
branch-gh-2408-iproto-watchers
locker
reviewed
Aug 1, 2022
|
|
||
| .. _box_protocol-watch: | ||
|
|
||
| IPROTO_WATCH = 0x4a |
There was a problem hiding this comment.
IPROTO_WATCH and IPROTO_UNWATCH should probably be listed in the Requests sub-section, because they are user requests. The description could just contain a reference to the Watchers sub-section, like IPROTO_AUTH refers to the Authentication sub-section.
| # <body> | ||
| msgpack({ | ||
| IPROTO_EVENT_KEY: :samp:`{{MP_STR string}}}`, | ||
| IPROTO_EVENT_DATA: :samp:`{{MP_NIL nil}}}` |
There was a problem hiding this comment.
From this description, it looks like the data can only be MP_NIL, but it can contain any valid MsgPack, not just MP_NIL.
github-actions
bot
temporarily deployed
to
branch-gh-2408-iproto-watchers
p7nov
pushed a commit
that referenced
this pull request
Aug 11, 2022
Written by Kseniia Antonova Proofread by Patience Daur Co-authored-by: Kseniia Antonova <[email protected]> Co-authored-by: Patience Daur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2408
Deploy: