Skip to content

Add tt check, logrotate, connect #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 3, 2022
Merged

Add tt check, logrotate, connect #3051

merged 6 commits into from
Aug 3, 2022

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Jul 26, 2022 •
edited
Loading

Resolves #2557 #2558 #2559

Also, fixes the descriptions in tt start docs (clear distinction between an application file and a running instance)

@p7nov p7nov marked this pull request as draft July 26, 2022 05:58
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 26, 2022 06:01 Inactive
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 26, 2022 07:03 Inactive
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 26, 2022 08:38 Inactive
@p7nov p7nov changed the title Add tt check Add tt check, logrotate, connect Jul 26, 2022
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 28, 2022 05:10 Inactive
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 28, 2022 05:40 Inactive
@github-actions github-actions bot temporarily deployed to branch-tt-check-connect July 28, 2022 05:57 Inactive
@p7nov p7nov marked this pull request as ready for review July 28, 2022 06:06
@p7nov p7nov requested a review from LeonidVas July 28, 2022 06:06
LeonidVas
LeonidVas approved these changes Aug 2, 2022
View reviewed changes
Copy link

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p7nov p7nov requested review from patiencedaur and xuniq and removed request for patiencedaur August 2, 2022 09:15
@patiencedaur patiencedaur requested review from patiencedaur and removed request for xuniq August 2, 2022 11:58
patiencedaur
patiencedaur suggested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@patiencedaur patiencedaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important note. Everything else LGTM :)

@github-actions github-actions bot temporarily deployed to branch-tt-check-connect August 3, 2022 04:21 Inactive
@p7nov p7nov requested a review from patiencedaur August 3, 2022 04:28
@p7nov p7nov merged commit ef33b9a into latest Aug 3, 2022
@p7nov p7nov deleted the tt-check-connect branch August 3, 2022 05:23
p7nov added a commit that referenced this pull request Aug 11, 2022
@p7nov
Add tt check, logrotate, connect (#3051)
8e2dc96 
Resolves #2557
Resolves #2558
Resolves #2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patiencedaur patiencedaur patiencedaur approved these changes

@LeonidVas LeonidVas LeonidVas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] tt check
3 participants
@p7nov @patiencedaur @LeonidVas