Skip to content

Use a new configuration approach for bootstrapping a database in SQL tutorials #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 21, 2023

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Dec 4, 2023

@xuniq xuniq changed the base branch from latest to 3.0 December 4, 2023 08:54
@xuniq xuniq marked this pull request as ready for review December 6, 2023 09:00
@xuniq xuniq force-pushed the gh-3672 branch 2 times, most recently from dbdb4b0 to 269d45e Compare December 8, 2023 08:15
@xuniq xuniq requested a review from Totktonada December 8, 2023 08:27
Comment on lines 164 to 167
.. code-block:: console

local function bootstrap()
$ cd
$ nano /etc/tarantool/instances.available/example.lua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this part should be reviewed with @psergee.

AFAIU, we want to create a system wide instance and use tarantoolctl's layout here. AFAIK, tt supports it. However, it also may provide better ways to install things into a system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does not seem to work. Yes, tt can work with tarantoolctl layout for single-script instances. But here we have a config. To make tt work with config.y[a]ml and instances.y[a]ml, these files must be placed in a sub-directory of instances.enabled:

  • Instead of an example.lua, a user should create /etc/tarantool/instances.available/mysql/init.lua
  • Create config.yml and instances.yml in the mysql dir from the step above
  • Create a link in instances.enabled to this mysql directory.

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I don't like this manual. A lot of 'put files here and there' actions are cumbersome. We should provide deb/rpm packages for such purposes and the commands should be mostly apt-get install <...> plus edit config plus systemctl start <...>.

However, I don't mind a slight update to sync it with recent tarantool versions and the tooling around. If the new steps are working, they're likely OK.

Please, review with tt guys and proceed.

@xuniq xuniq merged commit 1d6dd6c into 3.0 Dec 21, 2023
@xuniq xuniq deleted the gh-3672 branch December 21, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Config] Use a new configuration approach for bootstrapping a database in SQL tutorials
4 participants