-
Notifications
You must be signed in to change notification settings - Fork 43
Use a new configuration approach for bootstrapping a database in SQL tutorials #3891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbdb4b0
to
269d45e
Compare
doc/how-to/sql/improving_mysql.rst
Outdated
.. code-block:: console | ||
|
||
local function bootstrap() | ||
$ cd | ||
$ nano /etc/tarantool/instances.available/example.lua |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this part should be reviewed with @psergee.
AFAIU, we want to create a system wide instance and use tarantoolctl's layout here. AFAIK, tt
supports it. However, it also may provide better ways to install things into a system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach does not seem to work. Yes, tt
can work with tarantoolctl
layout for single-script instances. But here we have a config. To make tt
work with config.y[a]ml
and instances.y[a]ml
, these files must be placed in a sub-directory of instances.enabled
:
- Instead of an
example.lua
, a user should create/etc/tarantool/instances.available/mysql/init.lua
- Create
config.yml
andinstances.yml
in themysql
dir from the step above - Create a link in
instances.enabled
to thismysql
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I don't like this manual. A lot of 'put files here and there' actions are cumbersome. We should provide deb/rpm packages for such purposes and the commands should be mostly apt-get install <...>
plus edit config plus systemctl start <...>
.
However, I don't mind a slight update to sync it with recent tarantool versions and the tooling around. If the new steps are working, they're likely OK.
Please, review with tt
guys and proceed.
Fixes #3672
What has been done:
Updated
Improving MySQL with Tarantool
page: https://github.com/tarantool/doc/pull/3891/files#diff-c243191ef89b4e031a1f3631024a625cf0e5fb513791f0ffccde63e351bc33a9L1Updated
SQL tutorial
page: https://github.com/tarantool/doc/pull/3891/files#diff-95e6dc7b9efa335f728ba27ba49e8b0684201521ed5c2de7747d853e72b154e4L2Added
mysql
directory to thecode-snippets/snippets/config
folder (used in theImproving MySQL with Tarantool
tutorial). The directory contains.lua
file,config.yaml
, andinstances.yml
.https://github.com/tarantool/doc/pull/3891/files#diff-3fd0774b19b03018c1e7f4d5d3899e89811433354b0ab05f00d97b5f8c9a4c60R1
Staging: