Skip to content

Update tt commands descriptions to 2.1.2 #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

p7nov
Copy link
Contributor

@p7nov p7nov commented Feb 13, 2024

Resolves #3999 https://github.com/tarantool/enterprise_doc/issues/260 https://github.com/tarantool/enterprise_doc/issues/259

Update descriptions in tt commands reference to new application concept of Tarantool 3.0:

Deployment: https://docs.d.tarantool.io/en/doc/gh-3999-tt-2-0-commands-update/reference/tooling/tt_cli/commands/

@p7nov p7nov requested a review from psergee February 13, 2024 09:34
@p7nov p7nov force-pushed the gh-3999-tt-2-0-commands-update branch from f7ac385 to c8d3d46 Compare February 13, 2024 09:35
Copy link
Contributor

@psergee psergee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. lgtm.

@p7nov p7nov requested a review from andreyaksenov February 13, 2024 10:25
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions below


* Start only the ``master`` instance of the application stored in the ``app/`` directory inside ``instances_enabled``:
``tt start`` can start single Tarantool instances without cluster configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without cluster configurations

I'd clarify this description with a link to the Configuration in code topic:

https://www.tarantool.io/en/doc/latest/concepts/configuration/configuration_code/

Now it is hard to understand that this instruction is for a legacy approach. `


``tt stop`` stops the specified running Tarantool instances.
``tt stop`` stops the specified running Tarantool applications or instances.
When called without arguments, stops all running applications in the current environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a link to tt start somewhere to allow a reader get more context. (Here and in other pages related to starting/stopping instances - status/restart/...)


You can combine different ways of passing variables in a single call of ``tt create``.

Application directory
~~~~~~~~~~~~~~~~~~~~~

By default, the application will appear in the directory named after the provided
By default, the application appears in the directory named after the provided
application name (``--name`` value).

To change the application location, use the ``-dst`` flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a link to the dst flag. (and maybe change flag -> option :) )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed flag to option across the page.

Not sure we need links to options on the same page with their reference. There is a lot of such mentionings in usage explanation and we don't normally add links (on the same page).

The application files must be stored inside the ``instances_enabled``
directory specified in the :ref:`tt configuration file <tt-config_file_app>`.
The ``APPLICATION`` value can be:
Cluster application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, let's consider restructuring of such pages to reflect that multi-instance apps can both use new and old config.

@p7nov p7nov requested a review from andreyaksenov February 14, 2024 07:24

* Restart all instances of the application stored in the ``app/`` directory inside
``instances_enabled`` in accordance with the :ref:`instances configuration <tt-instances>`:
* Restart only the ``master`` instance of the ``app`` application with automatic confirmation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Suggested change
* Restart only the ``master`` instance of the ``app`` application with automatic confirmation:
* Restart only the ``master`` instance of the ``app`` application with automatic confirmation:

@p7nov p7nov merged commit 9980524 into latest Feb 14, 2024
@p7nov p7nov deleted the gh-3999-tt-2-0-commands-update branch February 14, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tt 2.0: changes in basic commands
3 participants