-
Notifications
You must be signed in to change notification settings - Fork 43
Add tt [cluster] replicaset promote/demote reference #4194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some minor comments below.
Suggestion: shouldn't we use more consistent names for these topics?
For example:
Managing replica sets
Managing cluster configurations
(orManaging clusters
?)
|
||
.. include:: _includes/cartridge_deprecation_note.rst | ||
|
||
``tt replicaset promote`` promotes instances in Cartridge clusters the following way: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``tt replicaset promote`` promotes instances in Cartridge clusters the following way: | |
``tt replicaset promote`` promotes instances in Cartridge clusters in the following way: |
They all apply to both etcd and Tarantool-based storages. The following list | ||
shows these ways ordered by precedence, from highest to lowest: | ||
|
||
#. Credentials specified in the storage URI: ``https://username:password@host:port/prefix``: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use an unordered list here
In this case, the command selects the key for patching automatically. A key's priority | ||
is determined by the detail level of the instance or replicaset configuration stored | ||
under this key. For example, when failover is ``off``, a key with | ||
``instance.database`` options takes precedence over a key with the only ``instance`` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instance.database
options takes
option or take?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subject (a key with "database" options
) takes precedence ...
In the ``election`` failover mode, ``tt replicaset promote`` initiates the new leader | ||
election by calling :ref:`box_ctl-promote` on the specified instance. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd added a third list item to the list above to make this info more visible. In this case, a reader gets all the required "concepts" in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've separated it because of conceptually different action: in this case, the command doesn't write the cluster config (unlike with failover off
or manual
). Also, the tt environment doesn't matter in this case (the paragraph above).
$ tt cluster show myapp | ||
|
||
.. _tt-cluster-centralized: | ||
.. _tt-cluster-publish-centralized: | ||
|
||
Managing configurations in centralized storages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Managing configurations in centralized storages
Publishing ?
Co-authored-by: Andrey Aksenov <[email protected]>
Resolves #4088 #4109 #4121
promote
anddemote
commandstt cluster replicaset
,promote
anddemote
subsectionsDeployment: https://docs.d.tarantool.io/en/doc/gh-4088-tt-replicaset-promote/reference/tooling/tt_cli/replicaset/#tt-replicaset-promote