tests: queue tests fail #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
3 times, most recently
from
221b01d to
3e71f41
Compare
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
from
3e71f41 to
876a8f2
Compare
|
Btw, commit name is confusing: queue tests are fixed now, they fail no more. |
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
from
876a8f2 to
fc3e382
Compare
Fixed. |
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
11 times, most recently
from
e908f0b to
6ba27e0
Compare
|
Sorry, I removed the branch and closed the issue by mistake. Everything should be restored now. |
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
from
6ba27e0 to
5fbcdfb
Compare
|
For clarity: in module queue space |
ligurio
requested changes
Jan 31, 2022
DifferentialOrange
approved these changes
Jan 31, 2022
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
from
5fbcdfb to
ec8d114
Compare
Before this patch, queue tests failed due to impossibility to use _queue_taken, which was deprecated in tarantool/queue [1]. Switch to _queue_taken_2 fixed it. Create access and some other actions were denied for test user. Additional grants fixed this problem. The test `TestUtube_Put` was affected by replacing timeout in the call of `TakeTimeout()` with timeout of connection structure. For clarification of this effect see annotation for function `TakeTimeout()` [2]. That was fixed by making connection timeout longer than the timeout in the function call. The step in testing.yml was uncommented for enabling queue tests in CI. 1. https://github.com/tarantool/queue/tree/7d05b6db5b0d596db4281d53b57811e156234a0d#fields-of-the-_queue_consumers-space 2. https://github.com/tarantool/go-tarantool/blob/master/queue/queue.go#L35 Fixes #115
vr009
force-pushed
the
vr009/gh-115-queue-tests-failure
branch
from
ec8d114 to
75efd65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: queue tests fix
Before this patch, queue tests failed due to impossibility to use _queue_taken,
which was deprecated in tarantool/queue [1]. Switch to _queue_taken_2 fixed it.
Create access and some other actions were denied for test user.
Additional grants fixed this problem.
The test
TestUtube_Putwas affected by replacing timeout in the callof
TakeTimeout()with timeout of connection structure. For clarificationof this effect see annotation for function
TakeTimeout()[2]. That wasfixed by making connection timeout longer than the timeout in the function call.
The step in testing.yml was uncommented for enabling queue tests in CI.
Fixes #115