Skip to content

github-ci: add workflow with golangci-lint and luacheck #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2022
Merged

github-ci: add workflow with golangci-lint and luacheck #154

merged 2 commits into from
Apr 12, 2022

Conversation

ligurio
Copy link
Member

@ligurio ligurio commented Apr 1, 2022 •
edited
Loading

Part of #142

@ligurio ligurio force-pushed the ligurio/gofmt branch 2 times, most recently from 0ea9256 to 25bc2a2 Compare April 1, 2022 13:52
@ligurio ligurio requested a review from LeonidVas April 1, 2022 13:57
@ligurio
Copy link
Member Author

ligurio commented Apr 1, 2022

Example of run: https://github.com/tarantool/go-tarantool/runs/5788968617?check_suite_focus=true

@ligurio ligurio force-pushed the ligurio/gofmt branch 5 times, most recently from 2eaeab0 to b9e3066 Compare April 7, 2022 13:06
@ligurio ligurio changed the title github-ci: add workflow with checking format github-ci: add workflow with checking format and luacheck Apr 7, 2022
@ligurio ligurio requested a review from Totktonada April 7, 2022 13:09
@ligurio ligurio force-pushed the ligurio/gofmt branch 3 times, most recently from 8869e28 to 65c825a Compare April 7, 2022 13:56
@ligurio ligurio changed the title github-ci: add workflow with checking format and luacheck github-ci: add workflow with 'go fmt', golangci-lint and luacheck Apr 7, 2022
@ligurio ligurio mentioned this pull request Apr 8, 2022
Closed
@ligurio ligurio force-pushed the ligurio/gofmt branch 2 times, most recently from 24e4596 to a9c8b71 Compare April 12, 2022 16:24
@ligurio ligurio changed the title github-ci: add workflow with 'go fmt', golangci-lint and luacheck github-ci: add workflow with golangci-lint and luacheck Apr 12, 2022
@ligurio
github-ci: add a job with luacheck
f67a26e 
luacheck config has been already added in commit
'lua: fix code style in test scripts' (17b725f).
As well as fixes for warnings found by luacheck.

Part of #142
Totktonada
Totktonada approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@ligurio ligurio merged commit 7897baf into master Apr 12, 2022
@ligurio ligurio deleted the ligurio/gofmt branch April 12, 2022 18:07
@ligurio ligurio mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Totktonada Totktonada Totktonada approved these changes

@LeonidVas LeonidVas Awaiting requested review from LeonidVas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ligurio @Totktonada